Report undeclared lifetimes during late resolution. #95779

cjgillot · 2022-04-07T19:23:11Z

First step in #91557

We reuse the rib design of the current resolution framework. Specific LifetimeRib and LifetimeRibKind types are introduced. The most important variant is LifetimeRibKind::Generics, which happens each time we encounter something which may introduce generic lifetime parameters. It can be an item or a for<...> binder. The LifetimeBinderKind specifies how this rib behaves with respect to in-band lifetimes.

r? @petrochenkov

rust-highfive · 2022-04-07T19:23:14Z

Some changes occurred in src/tools/rustfmt.

cc @calebcartwright

compiler/rustc_resolve/src/late.rs

petrochenkov · 2022-04-13T17:47:52Z

compiler/rustc_resolve/src/late.rs

+    }
+
+    #[tracing::instrument(level = "debug", skip(self))]
+    fn resolve_anonymous_lifetime(&mut self, lifetime: &Lifetime, elided: bool) {


This function is confusing because it doesn't actually resolve anything, only reports errors, but I guess the missing part is just introduced in some future commit.

compiler/rustc_resolve/src/late.rs

compiler/rustc_resolve/src/late/diagnostics.rs

petrochenkov · 2022-04-14T11:26:54Z

r=me after addressing #95779 (comment) and squashing review commits into main commits.

cjgillot · 2022-04-14T17:17:14Z

@bors try @rust-timer queue

rust-timer · 2022-04-14T17:17:15Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-04-14T17:17:22Z

⌛ Trying commit d136af68aa1dd6735d0201a12769cc89e489be04 with merge 084f7019b88c60ebb175e17abc7c6515be0a04b7...

bors · 2022-04-14T18:42:28Z

☀️ Try build successful - checks-actions
Build commit: 084f7019b88c60ebb175e17abc7c6515be0a04b7 (084f7019b88c60ebb175e17abc7c6515be0a04b7)

rust-timer · 2022-04-14T18:42:30Z

Queued 084f7019b88c60ebb175e17abc7c6515be0a04b7 with parent e7575f9, future comparison URL.

rust-timer · 2022-04-14T20:30:24Z

Finished benchmarking commit (084f7019b88c60ebb175e17abc7c6515be0a04b7): comparison url.

Summary:

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	75	40	0	1	75
mean²	0.5%	0.4%	N/A	-0.3%	0.5%
max	0.9%	0.9%	N/A	-0.3%	0.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

number of relevant changes ↩
the arithmetic mean of the percent change ↩

petrochenkov · 2022-04-14T21:04:22Z

With this PR compiler does some double work when resolving lifetimes, and the performance should be recovered when other parts of #91557 land.
@bors r+

bors · 2022-04-14T21:04:24Z

📌 Commit d136af68aa1dd6735d0201a12769cc89e489be04 has been approved by petrochenkov

petrochenkov · 2022-04-17T11:17:42Z

@bors r+

bors · 2022-04-17T11:17:43Z

📌 Commit e628df9 has been approved by petrochenkov

bors · 2022-04-17T12:56:22Z

⌛ Testing commit e628df9 with merge 1ec2c13...

bors · 2022-04-17T15:17:11Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 1ec2c13 to master...

rust-timer · 2022-04-17T16:36:48Z

Finished benchmarking commit (1ec2c13): comparison url.

Summary:

Primary benchmarks: mixed results
Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	58	39	1	2	59
mean²	0.5%	0.5%	-2.5%	-1.0%	0.5%
max	0.8%	1.1%	-2.5%	-1.0%	-2.5%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

number of relevant changes ↩
the arithmetic mean of the percent change ↩

jackh726 · 2022-04-17T18:30:55Z

compiler/rustc_hir/src/hir.rs

@@ -95,7 +95,7 @@ pub enum LifetimeName {
    /// User wrote nothing (e.g., the lifetime in `&u32`).
    ///
    /// The bool indicates whether the user should have written something.


This comment is now out of date.

pnkfelix · 2022-04-21T02:55:09Z

Visiting for weekly performance triage

These performance regressions were anticipated (via measurement) during review of the PR and effectively already triaged.

@rustbot label: +perf-regression-triaged

…petrochenkov Report undeclared lifetimes during late resolution. First step in rust-lang#91557 We reuse the rib design of the current resolution framework. Specific `LifetimeRib` and `LifetimeRibKind` types are introduced. The most important variant is `LifetimeRibKind::Generics`, which happens each time we encounter something which may introduce generic lifetime parameters. It can be an item or a `for<...>` binder. The `LifetimeBinderKind` specifies how this rib behaves with respect to in-band lifetimes. r? `@petrochenkov`

rust-highfive assigned petrochenkov Apr 7, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 7, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2022

This comment was marked as resolved.

Sign in to view

petrochenkov reviewed Apr 13, 2022

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2022

cjgillot force-pushed the ast-lifetimes-undeclared branch from 1b77723 to d128994 Compare April 13, 2022 20:06

cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2022

petrochenkov reviewed Apr 14, 2022

View reviewed changes

compiler/rustc_resolve/src/late/diagnostics.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2022

cjgillot force-pushed the ast-lifetimes-undeclared branch from d128994 to d136af6 Compare April 14, 2022 17:16

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 14, 2022

rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 14, 2022

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2022

cjgillot added 7 commits April 17, 2022 11:03

Visit generics inside visit_fn.

e47f66d

Remove is_in_fn_syntax.

4cfceea

Report undeclared lifetimes on AST.

fc9f255

Bless tests.

ca57bad

Lint elided lifetimes in path on the AST.

a9e13fa

Bless clippy.

35eac35

Bless nll test.

e628df9

cjgillot force-pushed the ast-lifetimes-undeclared branch from d136af6 to e628df9 Compare April 17, 2022 10:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 17, 2022

bors merged commit 1ec2c13 into rust-lang:master Apr 17, 2022

rustbot added this to the 1.62.0 milestone Apr 17, 2022

bors mentioned this pull request Apr 17, 2022

Perform lifetime resolution on the AST for lowering #91557

Merged

cjgillot deleted the ast-lifetimes-undeclared branch April 17, 2022 15:40

This was referenced Apr 17, 2022

Stabilize let_chains in Rust 1.64 #94927

Merged

Improve error message for impl Self #95041

Closed

Enforce static lifetimes in consts during late resolution #95776

Merged

jackh726 reviewed Apr 17, 2022

View reviewed changes

rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 21, 2022

matthiaskrgr mentioned this pull request May 11, 2022

[ICE] Unresolved HRTB lifetime in APIT #96954

Closed

steffahn mentioned this pull request Jun 9, 2022

ICE: 'no entry found for key' when using for<T> T: Copy in current nightly and beta #97836

Closed

dwrensha mentioned this pull request Oct 6, 2022

Region parameter out of range when substituting in region #102751

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report undeclared lifetimes during late resolution. #95779

Report undeclared lifetimes during late resolution. #95779

cjgillot commented Apr 7, 2022

rust-highfive commented Apr 7, 2022

This comment was marked as resolved.

petrochenkov Apr 13, 2022

petrochenkov commented Apr 14, 2022

cjgillot commented Apr 14, 2022

rust-timer commented Apr 14, 2022

bors commented Apr 14, 2022

bors commented Apr 14, 2022

rust-timer commented Apr 14, 2022

rust-timer commented Apr 14, 2022

petrochenkov commented Apr 14, 2022

bors commented Apr 14, 2022

petrochenkov commented Apr 17, 2022

bors commented Apr 17, 2022

bors commented Apr 17, 2022

bors commented Apr 17, 2022

rust-timer commented Apr 17, 2022

jackh726 Apr 17, 2022

pnkfelix commented Apr 21, 2022

Report undeclared lifetimes during late resolution. #95779

Report undeclared lifetimes during late resolution. #95779

Conversation

cjgillot commented Apr 7, 2022

rust-highfive commented Apr 7, 2022

This comment was marked as resolved.

petrochenkov Apr 13, 2022

Choose a reason for hiding this comment

petrochenkov commented Apr 14, 2022

cjgillot commented Apr 14, 2022

rust-timer commented Apr 14, 2022

bors commented Apr 14, 2022

bors commented Apr 14, 2022

rust-timer commented Apr 14, 2022

rust-timer commented Apr 14, 2022

Footnotes

petrochenkov commented Apr 14, 2022

bors commented Apr 14, 2022

petrochenkov commented Apr 17, 2022

bors commented Apr 17, 2022

bors commented Apr 17, 2022

bors commented Apr 17, 2022

rust-timer commented Apr 17, 2022

Footnotes

jackh726 Apr 17, 2022

Choose a reason for hiding this comment

pnkfelix commented Apr 21, 2022