Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for wasm32-unknown-unknown #95900

Merged
merged 1 commit into from Apr 12, 2022
Merged

Fix documentation for wasm32-unknown-unknown #95900

merged 1 commit into from Apr 12, 2022

Conversation

o01eg
Copy link
Contributor

@o01eg o01eg commented Apr 10, 2022

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 11, 2022

📌 Commit 26781c3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 11, 2022
@Dylan-DPC
Copy link
Member

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 11, 2022
@o01eg
Copy link
Contributor Author

o01eg commented Apr 11, 2022

On Windows it gives:

error: unresolved link to `AsFd::as_fd`
  --> library\std\src\os\fd\raw.rs:35:60
   |
35 |     /// However, borrowing is not strictly required. See [`AsFd::as_fd`]
   |                                                            ^^^^^^^^^^^ no item named `AsFd` in scope
   |
   = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`

Maybe I should somehow rephrase it because without it I get:

error[E0432]: unresolved import `crate::os::unix::io`
 --> library/std/src/os/fd/raw.rs:9:22
  |
9 | use crate::os::unix::io::AsFd;
  |                      ^^ could not find `io` in `unix`

@o01eg
Copy link
Contributor Author

o01eg commented Apr 11, 2022

I've tried to fix it and rebased PR.

@Dylan-DPC
Copy link
Member

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Apr 11, 2022

📌 Commit 3f4bbd5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 11, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 12, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95671 (feat: Allow usage of sudo [while not accessing root] in x.py)
 - rust-lang#95716 (sess: warn w/out fluent bundle w/ user sysroot)
 - rust-lang#95820 (simplify const params diagnostic on stable)
 - rust-lang#95900 (Fix documentation for wasm32-unknown-unknown)
 - rust-lang#95947 (`impl const Default for Box<[T]>` and `Box<str>`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cdbdf1e into rust-lang:master Apr 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 12, 2022
@o01eg o01eg deleted the fix-wasm-doc branch April 12, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc fails to build wasm32 target documentation
6 participants