Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #96101

Closed
wants to merge 28 commits into from
Closed

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Michcioperz and others added 28 commits March 4, 2022 13:39
Also sort sidebar alphabetically by document filename
The code was broken anyway, if the deaggregator is disabled, it would have ICE on any non-enum Adt
update: actions/checkout@v2 to actions/checkout@v3 for all yaml files

Revert "update: actions/checkout@v2 to actions/checkout@v3 for all yaml files"

This reverts commit 7445e582b900f0f56f5f2bd9036aacab97ef28e9.

change GitHub Actions version v2 to v3

change GitHub Actions
The current "This is supported" wording implies that it's possible to
still use the item on other configurations, but in an unsupported way.
Changing this to "Available" removes this ambiguity.
…pnkfelix

Only add codegen backend to dep info if -Zbinary-dep-depinfo is used

I am currently migrating the cg_clif build system from using a binary linked to the codegen backend as rustc replacement to passing `-Zcodegen-backend` instead. Without this PR this would force cargo to rebuild the sysroot on any change to the codegen backend even if I explicitly specify that I want it to be preserved, which would make development of cg_clif a lot slower. If you still want to have changes to the codegen backend invalidate the cargo build cache you can explicitly specify `-Zbinary-dep-depinfo`.

cc `@eddyb` as the codegen backend was initially added to the depinfo for rust-gpu.
Add missing links in platform support docs

I was looking at m68k support and saw that https://doc.rust-lang.org/rustc/platform-support.html and the sidebar there were missing some links to target documentation
…i-obk

make unaligned_references lint deny-by-default

This lint has been warn-by-default for a year now (since rust-lang#82525), so I think it is time to crank it up a bit. Code that triggers the lint causes UB (without `unsafe`) when executed, so we really don't want people to write code like this.
…comment, r=petrochenkov

Improve diagnostics for unterminated nested block comment

close rust-lang#95283

(This is my first time try to messing around with rust compiler and might get a lot of things wrong... 🙇 )
…rochenkov

Consider lifetimes when comparing types for equality in MIR validator

Closes rust-lang#95978 .
…hub-action-version, r=pietroalbini

Update GitHub Actions actions/checkout Version v2 -> v3

Update `actions/checkout@v2` to `actions/checkout@v3` because of Node12 will be out of life after Aril 30, 2022 [[Reference](https://nodejs.org/en/about/releases/)].
`actions/xxxx@v3` use Node16 whose support lasts until April 30, 2024.
…fJung

Remove some now-dead code that was only relevant before deaggregation.

The code was broken anyway, if the deaggregator is disabled, it would have ICEd on any non-enum Adt

r? ``@RalfJung``
…aumegomez

clarify doc(cfg) wording

The current "This is supported" wording implies that it's possible to
still use the item on other configurations, but in an unsupported way.
Changing this to "Available" removes this ambiguity.
…thomcc

[test] Add test cases for untested functions for BTreeMap

- add `pop_first()`, `pop_last()`, `get_key_value()` and `try_insert()` test cases
Update mdbook

This just brings in a few small fixes, particularly a rendering fix for chapter names with markdown in them (like the https://doc.rust-lang.org/nightly/rustc/platform-support/kmc-solid.html page).  There's also a minor fix for the search index for duplicate headings.

Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0418
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 16, 2022
@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 16, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Apr 16, 2022

📌 Commit 45af788 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 16, 2022
@bors
Copy link
Contributor

bors commented Apr 16, 2022

⌛ Testing commit 45af788 with merge b36d575e53f20d9089c8b06c21241cadbfd6aff0...

@bors
Copy link
Contributor

bors commented Apr 16, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    
    --- stdout
    
    running 8 tests
    test /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Iterators_vs_Array_Access (line 183) ... ignored
    test /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Volatile_Access (line 262) ... ignored
    test /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 350) ... FAILED
    test /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Preprocessor::Compile_Time_Sizes_and_Computation (line 78) ... ok
    test /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Preprocessor::Compile_Time_Code_Selection (line 44) ... ok
    test /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 312) ... ok
    test /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 373) ... ok
    test /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 330) ... ok
    failures:
    
    
    ---- /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 350) stdout ----
    error: reference to packed field is unaligned
      --> /tmp/mdbook-h02gzc/c-tips/index.md:361:41
       |
    12 |     unsafe { println!("{:p} {:p} {:p}", &v.x, &v.y, &v.z) };
       |
       |
       = note: `#[deny(unaligned_references)]` on by default
       = note: for more information, see issue #82523 <https://github.com/rust-lang/rust/issues/82523>
       = note: for more information, see issue #82523 <https://github.com/rust-lang/rust/issues/82523>
       = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
       = help: copy the field contents to a local variable, or replace the reference with a raw pointer and use `read_unaligned`/`write_unaligned` (loads and stores via `*p` must be properly aligned even when using raw pointers)
    error: reference to packed field is unaligned
    error: reference to packed field is unaligned
      --> /tmp/mdbook-h02gzc/c-tips/index.md:361:53
       |
    12 |     unsafe { println!("{:p} {:p} {:p}", &v.x, &v.y, &v.z) };
       |
       = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
       = note: for more information, see issue #82523 <https://github.com/rust-lang/rust/issues/82523>
       = note: for more information, see issue #82523 <https://github.com/rust-lang/rust/issues/82523>
       = note: fields of packed structs are not properly aligned, and creating a misaligned reference is undefined behavior (even if that reference is never dereferenced)
       = help: copy the field contents to a local variable, or replace the reference with a raw pointer and use `read_unaligned`/`write_unaligned` (loads and stores via `*p` must be properly aligned even when using raw pointers)
    error: aborting due to 2 previous errors
    
    Couldn't compile the test.
    
    
    failures:
        /tmp/mdbook-h02gzc/c-tips/index.md - Tips_for_embedded_C_developers::Packed_and_Aligned_Types (line 350)
    test result: FAILED. 5 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.21s
    
    
    --- stderr
---
.......... (60/62)
.         (62/62)


/checkout/src/test/rustdoc-gui/escape-key.goml escape-key... FAILED
[ERROR] (line 6) TimeoutError: waiting for selector "#search h1" failed: timeout 30000ms exceeded: for command `wait-for: "#search h1" // The search element is empty before the first search `
Build completed unsuccessfully in 0:00:41

@Dylan-DPC Dylan-DPC mentioned this pull request Apr 16, 2022
@Dylan-DPC Dylan-DPC closed this Apr 16, 2022
@Dylan-DPC Dylan-DPC deleted the rollup-4d315c3 branch April 16, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet