Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #96254

Merged
merged 1 commit into from
Apr 21, 2022
Merged

update Miri #96254

merged 1 commit into from
Apr 21, 2022

Conversation

RalfJung
Copy link
Member

Fixes #96239
r? @ghost

@RalfJung
Copy link
Member Author

Cc @rust-lang/miri
@bors r+ p=1

@bors
Copy link
Contributor

bors commented Apr 20, 2022

📌 Commit 47d64ee9c7a8b4f356a90d26009e9a48ccf0311b has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 20, 2022
@bors
Copy link
Contributor

bors commented Apr 20, 2022

⌛ Testing commit 47d64ee9c7a8b4f356a90d26009e9a48ccf0311b with merge 0c9e9f08309a28cfbc3a9a2c70e87b9df0a8754c...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 20, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2022
@RalfJung
Copy link
Member Author

#93313 broke Miri just before this PR got into the queue. I am on it.

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Apr 20, 2022

📌 Commit 1b01d65 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2022
@Dylan-DPC
Copy link
Member

@bors p=7

@bors
Copy link
Contributor

bors commented Apr 20, 2022

⌛ Testing commit 1b01d65 with merge 09ccb6c...

@bors
Copy link
Contributor

bors commented Apr 21, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 09ccb6c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2022
@bors bors merged commit 09ccb6c into rust-lang:master Apr 21, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 21, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #96254!

Tested on commit 09ccb6c.
Direct link to PR: #96254

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 21, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#96254!
22a2657 
Tested on commit rust-lang/rust@09ccb6c.
Direct link to PR: <rust-lang/rust#96254>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung @eddyb).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (09ccb6c): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 1 0 1
mean2 N/A N/A -1.6% N/A -1.6%
max N/A N/A -1.6% N/A -1.6%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@RalfJung RalfJung deleted the miri branch April 26, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#96224
7 participants
@RalfJung @bors @rust-log-analyzer @Dylan-DPC @rust-highfive @rust-timer @rustbot