Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #97694

Merged
merged 20 commits into from
Jun 3, 2022
Merged

Rollup of 3 pull requests #97694

merged 20 commits into from
Jun 3, 2022

Commits on Jun 1, 2022

  1. Rework prohibit_generics

    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    f023b92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b2d80a View commit details
    Browse the repository at this point in the history
  3. More accurately handle suggestions

    * Confirm the path segment being modified is an `enum`
    * Check whether type has type param before suggesting changing `Self`
    * Wording changes
    * Add clarifying comments
    * Suggest removing args from `Self` if the type doesn't have type params
    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    532671b View commit details
    Browse the repository at this point in the history
  4. Fix test

    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3d60691 View commit details
    Browse the repository at this point in the history
  5. Fix typo

    estebank committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    196a30e View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Make output more specific

    estebank committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    ad63f90 View commit details
    Browse the repository at this point in the history
  2. review comments

    estebank committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    cd8cfbf View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Configuration menu
    Copy the full SHA
    e0cbac6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe503ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7d1b5a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    584eec6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    72bd8e4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1e4a149 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7db2b00 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6ce2e05 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b1294e8 View commit details
    Browse the repository at this point in the history
  10. Compute is_late_bound in a separate query.

    The computation is actually much simpler, and can be done by directly
    fetching the HIR for the `FnDecl` and its generics.
    cjgillot committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    ba40fe9 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#97415 - cjgillot:is-late-bound-solo, r=este…

    …bank
    
    Compute `is_late_bound_map` query separately from lifetime resolution
    
    This query is actually very simple, and is only useful for functions and method.  It can be computed directly by fetching the HIR, with no need to embed it within the lifetime resolution visitor.
    
    Based on rust-lang#96296
    Dylan-DPC committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    53ab3b2 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#97471 - estebank:prohibit-generics, r=cjgillot

    Provide more context when denying invalid type params
    Dylan-DPC committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    6b80b15 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5549d50 View commit details
    Browse the repository at this point in the history