session: stabilize split debuginfo on linux #98051

davidtwco · 2022-06-13T11:02:24Z

Stabilize the -Csplit-debuginfo flag...

...on Linux for all values of the flag. Split DWARF has been implemented for a few months, hasn't had any bug reports and has had some promising benchmarking for incremental debug build performance.
..on other platforms for the default value. It doesn't make any sense that -Csplit-debuginfo=packed is unstable on Windows MSVC when that's the default behaviour, but keep the other values unstable.

rust-highfive · 2022-06-13T11:02:27Z

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2022-06-13T11:02:28Z

⚠️ Warning ⚠️

These commits modify compiler targets. (See the Target Tier Policy.)

davidtwco · 2022-06-13T11:02:36Z

Stabilization report

I think it's been long enough that we can stabilize split debuginfo on some more platforms:

On Linux, all values of -Csplit-debuginfo are stabilized.
On other platforms, the default value of the option (e.g. -Csplit-debuginfo=packed on Windows).

@rfcbot fcp merge

Brief summary

rustc already has support on stable for split debuginfo on Windows (*.pdb) and macOS (*.dSYM), but is missing support for split debuginfo on Linux (Split DWARF's *.dwp/*.dwo files).

rustc's existing support (as of rustc stable 1.61, released May 19th 2022) for split debuginfo is platform-dependent and exposed through the -Csplit-debuginfo compiler flag:

-Csplit-debuginfo=off
- Split debuginfo is not desired, debuginfo should be in the final artifact.
- Windows: -Csplit-debuginfo=off is not supported. Debuginfo is always separate on Windows. Unstable.
- macOS: -Csplit-debuginfo=off is supported, dsymutil is not executed. Stable.
- Linux: -Csplit-debuginfo=off is supported and is the default. Unstable. This pull request is proposing to stabilize this option on this platform.
-Csplit-debuginfo=unpacked
- Split debuginfo is in many separate files, spread throughout the build directory. unpacked split debuginfo might be contained within object files or in separate files, depending on the platform.
- Windows: -Csplit-debuginfo=unpacked is not supported. Debuginfo is always packed on Windows. Unstable.
- macOS: -Csplit-debuginfo=unpacked is supported, dsymutil is not executed. Stable.
- Linux: -Csplit-debuginfo=unpacked is supported. Unstable. This pull request is proposing to stabilize this option on this platform.
-Csplit-debuginfo=packed
- Split debuginfo is desired in a single location separate from the executable.
- Windows: -Csplit-debuginfo=packed is supported and the default, debuginfo packed into a .pdb file. Unstable. This pull request is proposing to stabilize this option on this platform (despite being the default, using the flag isn't actually allowed right now).
- macOS: -Csplit-debuginfo=packed is supported and the default, debuginfo packed into a .dSYM file. Stable.
- Linux: -Csplit-debuginfo=packed is supported. Unstable. This pull request is proposing to stabilize this option on this platform.

Split DWARF is a new addition to the DWARF specification, starting in version 5 (released February 2017). Prior versions of DWARF supported Split DWARF through extensions to the specification by the GNU project ("Debug Fission" project).

With Split DWARF, debuginfo which does not require link-time relocation is split and is not processed by the linker, resulting in time/memory link-time savings and smaller output.

Split DWARF adds support for -Csplit-debuginfo on Linux platforms, and adds the -Zsplit-dwarf-kind flag (-Csplit-dwarf-kind once stabilized, which is not being proposed in this pull request):

-Cdebuginfo=0 -Csplit-debuginfo=off
- No debug information.
-Cdebuginfo=2 -Csplit-debuginfo=off
- Debug information in relocatable object files (.o), linked into the final executable.
-Cdebuginfo=2 -Csplit-debuginfo=unpacked -Zsplit-dwarf-kind=single
- Debug information in relocatable object files (.o), ignored by the linker, not in the final executable.
-Cdebuginfo=2 -Csplit-debuginfo=packed -Zsplit-dwarf-kind=single
- Debug information in relocatable object files (.o), ignored by the linker, not in the final executable. Packaged from relocatable object files (.o) into dwarf package (.dwp).
-Cdebuginfo=2 -Csplit-debuginfo=unpacked (uses the default of -Zsplit-dwarf-kind=split)
- Debug information in dwarf object files (.dwo), not in the final executable.
-Cdebuginfo=2 -Csplit-debuginfo=packed (uses the default of -Zsplit-dwarf-kind=split)
- Debug information in dwarf object files (.dwo), not in the final executable.
- Packaged from dwarf object files (.dwo) into dwarf package (.dwp).

Implementation History

debuginfo: Add support for split-debuginfo on platforms that allow it #34651 (original issue)
cg_llvm: split dwarf support #77117 (initial implementation of Split DWARF)
bootstrap: include llvm-dwp in CI LLVM #80087 (adding llvm-dwp to the CI)
Implement rust-lang/thorin - a Rust implementation of a DWARF packaging utility
cg: split dwarf for crate dependencies #89819 (using thorin in rustc instead of llvm-dwp)
bootstrap: add split-debuginfo config #95612 (adding split-debuginfo option to config.toml)
bootstrap: bsd platform flags for split debuginfo #96758 (fixing fallout from bootstrap: add split-debuginfo config #95612)
[PERF] split dwarf benchmarking #96199 (benchmarking of Split DWARF)
incr.comp.: Make split-dwarf commandline options [TRACKED]. #98886 (tracking Split DWARF flags in incremental compilation)
incr: cache dwarf objects in work products #98901 (including DWARF objects in work products)

Open issues

split-debuginfo documentation contradiction cargo#12243 (documentation inconsistency between cargo and rustc regarding split debuginfo)
- Shouldn't block stabilization.

rfcbot · 2022-06-13T11:02:37Z

davidtwco · 2022-06-13T11:03:05Z

compiler/rustc_target/src/spec/mod.rs

+            };
+        }
+
+        // Other platforms use Split DWARF, which is stable.


I'm slightly unsure about this, but not sure what check would be appropriate.

This effectively stabilizes all forms on split debuginfo on platforms like Fuchsia, Solaris, BSD, etc, right? Is that really what we want? The stabilization report only mentions Linux.

Yeah, I wasn't sure how best to say "anything that uses DWARF for debuginfo". I've changed this to take a very different approach so that each target now specifies the different values of SplitDebuginfo that it supports, that lets us toggle this on in a much more fine-grained way for each target.

I suspect it'll take a couple runs through bors to limit the tests to the correct platforms now though..

compiler/rustc_target/src/spec/mod.rs

michaelwoerister · 2022-07-01T13:44:04Z

@rfcbot concern INCR_COMP_INTERACTION

As discussed on Zulip, @davidtwco and I are not a 100% sure yet if the current implementation is sound when incremental compilation is being used. It probably isn't when -Zsplit-dwarf-kind=split is specified. Hopefully that's easy enough to fix though.

michaelwoerister · 2022-07-06T14:50:23Z

#98886 and #98901 solve all incr. comp. related issues I came across.

@rfcbot resolved INCR_COMP_INTERACTION

jackh726 · 2022-07-10T19:19:56Z

r? @michaelwoerister

rfcbot · 2022-07-19T13:14:56Z

🔔 This is now entering its final comment period, as per the review above. 🔔

bors · 2022-08-26T15:47:30Z

⌛ Testing commit cf2c492 with merge 450e99f...

bors · 2022-08-26T18:53:10Z

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 450e99f to master...

rust-timer · 2022-08-26T20:07:32Z

Finished benchmarking commit (450e99f): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	2
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	6
Improvements ✅ (secondary)	-0.9%	[-1.1%, -0.6%]	6
All ❌✅ (primary)	-0.6%	[-0.7%, -0.5%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[1.5%, 9.1%]	11
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-5.1%, -2.1%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-3.7%, -3.7%]	1
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

lqd · 2022-08-26T21:23:04Z

Is deeply-nested-multi getting noisy recently ? It's the 3rd time we've seen it switch back and forth 1-2% today.

This PDB setting was added to `windows_msvc_base` in rust-lang#98051. It's also needed for the UEFI targets, and since `uefi_msvc_base` and `windows_msvc_base` are the only things that inherit from `msvc_base`, just move the PDB setting up to `mscv_base` to cover both. Fixes rust-lang#101071

nnethercote · 2022-08-28T22:27:30Z

Is deeply-nested-multi getting noisy recently ? It's the 3rd time we've seen it switch back and forth 1-2% today.

And a similar story for html5ever-0.26.0.

nnethercote · 2022-08-28T22:28:15Z

Based on the above, I think this is just noise.

@rustbot label: -perf-regression

…davidtwco Set DebuginfoKind::Pdb in msvc_base This PDB setting was added to `windows_msvc_base` in rust-lang#98051. It's also needed for the UEFI targets, and since `uefi_msvc_base` and `windows_msvc_base` are the only things that inherit from `msvc_base`, just move the PDB setting up to `mscv_base` to cover both. Fixes rust-lang#101071

…, r=davidtwco Update note about unstable split-debuginfo flag. split-debuginfo was effectively stabilized in rust-lang#98051. The note about it requiring `-Z unstable-options` is no longer accurate. The rules for when it is gated and when it is supported are somewhat complex. I considered removing the note entirely, or making it more generic, but opted to instead try to summarize the current state.

Pkgsrc changes: * We now manage to build for mipsel-unknown-netbsd, but despite the target spec saying cpu = "mips3", the compiler manages to emit 64-bit instructions which cause "illegal instruction" error. Will need more work. The mipsel-unknown-netbsd entry is commentd out since there is no 1.64.0 bootstrap. * Managed to retain the build of aarch64_be, llvm needed a patch to avoid use of neon instructions in the BE case (llvm doesn't support use of neon in BE mode). Ref. patch to src/llvm-project/llvm/lib/Support/BLAKE3/blake3_impl.h. * The minimum gcc version is now 7.x, and that includes the cross-compiler for the targets. For i386 this also needs to /usr/include/gcc-7 include files in the target root, because immintrin.h from gcc 5 is not compatible with gcc 7.x. This applies for the targets where we build against a root from netbsd-8 (sparc64, powerpc, i386), and files/gcc-wrap gets a hack for this. * Pick up tweak for -latomic inclusion from rust-lang/rust#104220 and rust-lang/rust#104572 * Retain ability to do 32-bit NetBSD, by changing from 64 to 32 bit types in library/std/src/sys/unix/thread_parker/netbsd.rs. * I've struggled a bit to get the "openssl-src" build with -latomic where it's needed. I introduce "NetBSD-generic32" system type and use it for the NetBSD mipsel target. There is another attempt to do the same in the patch to vendor/openssl-sys/build/main.rs. * Bump bootstraps to 1.64.0, checksum updates. Upstream changes: Version 1.65.0 (2022-11-03) ========================== Language -------- - [Error on `as` casts of enums with `#[non_exhaustive]` variants] (rust-lang/rust#92744) - [Stabilize `let else`](rust-lang/rust#93628) - [Stabilize generic associated types (GATs)] (rust-lang/rust#96709) - [Add lints `let_underscore_drop`, `let_underscore_lock`, and `let_underscore_must_use` from Clippy] (rust-lang/rust#97739) - [Stabilize `break`ing from arbitrary labeled blocks ("label-break-value")] (rust-lang/rust#99332) - [Uninitialized integers, floats, and raw pointers are now considered immediate UB](rust-lang/rust#98919). Usage of `MaybeUninit` is the correct way to work with uninitialized memory. - [Stabilize raw-dylib for Windows x86_64, aarch64, and thumbv7a] (rust-lang/rust#99916) - [Do not allow `Drop` impl on foreign ADTs] (rust-lang/rust#99576) Compiler -------- - [Stabilize -Csplit-debuginfo on Linux] (rust-lang/rust#98051) - [Use niche-filling optimization even when multiple variants have data] (rust-lang/rust#94075) - [Associated type projections are now verified to be well-formed prior to resolving the underlying type] (rust-lang/rust#99217) - [Stringify non-shorthand visibility correctly] (rust-lang/rust#100350) - [Normalize struct field types when unsizing] (rust-lang/rust#101831) - [Update to LLVM 15](rust-lang/rust#99464) - [Fix aarch64 call abi to correctly zeroext when needed] (rust-lang/rust#97800) - [debuginfo: Generalize C++-like encoding for enums] (rust-lang/rust#98393) - [Add `special_module_name` lint] (rust-lang/rust#94467) - [Add support for generating unique profraw files by default when using `-C instrument-coverage`] (rust-lang/rust#100384) - [Allow dynamic linking for iOS/tvOS targets] (rust-lang/rust#100636) New targets: - [Add armv4t-none-eabi as a tier 3 target] (rust-lang/rust#100244) - [Add powerpc64-unknown-openbsd and riscv64-unknown-openbsd as tier 3 targets] (rust-lang/rust#101025) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Don't generate `PartialEq::ne` in derive(PartialEq)] (rust-lang/rust#98655) - [Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default] (rust-lang/rust#101325) - [Forbid mixing `System` with direct system allocator calls] (rust-lang/rust#101394) - [Document no support for writing to non-blocking stdio/stderr] (rust-lang/rust#101416) - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`](rust-lang/rust#95295) This also changes the safety conditions on `Layout::from_size_align_unchecked`. Stabilized APIs --------------- - [`std::backtrace::Backtrace`] (https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html) - [`Bound::as_ref`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.as_ref) - [`std::io::read_to_string`] (https://doc.rust-lang.org/stable/std/io/fn.read_to_string.html) - [`<*const T>::cast_mut`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_mut) - [`<*mut T>::cast_const`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_const) These APIs are now stable in const contexts: - [`<*const T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) - [`<*mut T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) Cargo ----- - [Apply GitHub fast path even for partial hashes] (rust-lang/cargo#10807) - [Do not add home bin path to PATH if it's already there] (rust-lang/cargo#11023) - [Take priority into account within the pending queue] (rust-lang/cargo#11032). This slightly optimizes job scheduling by Cargo, with typically small improvements on larger crate graph builds. Compatibility Notes ------------------- - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`] (rust-lang/rust#95295). This also changes the safety conditions on `Layout::from_size_align_unchecked`. - [`PollFn` now only implements `Unpin` if the closure is `Unpin`] (rust-lang/rust#102737). This is a possible breaking change if users were relying on the blanket unpin implementation. See discussion on the PR for details of why this change was made. - [Drop ExactSizeIterator impl from std::char::EscapeAscii] (rust-lang/rust#99880) This is a backwards-incompatible change to the standard library's surface area, but is unlikely to affect real world usage. - [Do not consider a single repeated lifetime eligible for elision in the return type] (rust-lang/rust#103450) This behavior was unintentionally changed in 1.64.0, and this release reverts that change by making this an error again. - [Reenable disabled early syntax gates as future-incompatibility lints] (rust-lang/rust#99935) - [Update the minimum external LLVM to 13] (rust-lang/rust#100460) - [Don't duplicate file descriptors into stdio fds] (rust-lang/rust#101426) - [Sunset RLS](rust-lang/rust#100863) - [Deny usage of `#![cfg_attr(..., crate_type = ...)]` to set the crate type] (rust-lang/rust#99784) This strengthens the forward compatibility lint deprecated_cfg_attr_crate_type_name to deny. - [`llvm-has-rust-patches` allows setting the build system to treat the LLVM as having Rust-specific patches] (rust-lang/rust#101072) This option may need to be set for distributions that are building Rust with a patched LLVM via `llvm-config`, not the built-in LLVM. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add `x.sh` and `x.ps1` shell scripts] (rust-lang/rust#99992) - [compiletest: use target cfg instead of hard-coded tables] (rust-lang/rust#100260) - [Use object instead of LLVM for reading bitcode from rlibs] (rust-lang/rust#98100) - [Enable MIR inlining for optimized compilations] (rust-lang/rust#91743) This provides a 3-10% improvement in compiletimes for real world crates. See [perf results] (https://perf.rust-lang.org/compare.html?start=aedf78e56b2279cc869962feac5153b6ba7001ed&end=0075bb4fad68e64b6d1be06bf2db366c30bc75e1&stat=instructions:u).

Pkgsrc changes: * pkglint cleanups, bump bootstrap kits to 1.65.0. * New target: mipsel-unknown-netbsd, for cpu=mips32 with soft-float. * Managed to retain the build of aarch64_be, llvm needed a patch to avoid use of neon instructions in the BE case (llvm doesn't support use of neon in BE mode). Ref. patch to src/llvm-project/llvm/lib/Support/BLAKE3/blake3_impl.h. Also submitted upstream of LLVM to the BLAKE3 maintainers. * The minimum gcc version is now 7.x, and that includes the cross-compiler for the targets. For i386 this also needs to /usr/include/gcc-7 include files in the target root, because immintrin.h from gcc 5 is not compatible with gcc 7.x. This applies for the targets where we build against a root from netbsd-8 (sparc64, powerpc, i386), and files/gcc-wrap gets a hack for this. * Pick up tweak for -latomic inclusion from rust-lang/rust#104220 and rust-lang/rust#104572 * Retain ability to do 32-bit NetBSD, by changing from 64 to 32 bit types in library/std/src/sys/unix/thread_parker/netbsd.rs. * I've tried to get the "openssl-src" build with -latomic where it's needed. I've introduced the "NetBSD-generic32" system type and use it for the NetBSD mipsel target. There is another attempt to do the same in the patch to vendor/openssl-sys/build/main.rs. Upstream changes: Version 1.66.1 (2023-01-10) =========================== - Added validation of SSH host keys for git URLs in Cargo ([CVE-2022-46176](https://www.cve.org/CVERecord?id=CVE-2022-46176)) Version 1.66.0 (2022-12-15) =========================== Language -------- - [Permit specifying explicit discriminants on all `repr(Int)` enums](rust-lang/rust#95710) ```rust #[repr(u8)] enum Foo { A(u8) = 0, B(i8) = 1, C(bool) = 42, } ``` - [Allow transmutes between the same type differing only in lifetimes](rust-lang/rust#101520) - [Change constant evaluation errors from a deny-by-default lint to a hard error](rust-lang/rust#102091) - [Trigger `must_use` on `impl Trait` for supertraits](rust-lang/rust#102287) This makes `impl ExactSizeIterator` respect the existing `#[must_use]` annotation on `Iterator`. - [Allow `..X` and `..=X` in patterns](rust-lang/rust#102275) - [Uplift `clippy::for_loops_over_fallibles` lint into rustc](rust-lang/rust#99696) - [Stabilize `sym` operands in inline assembly](rust-lang/rust#103168) - [Update to Unicode 15](rust-lang/rust#101912) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. Compiler -------- - [Add armv5te-none-eabi and thumbv5te-none-eabi tier 3 targets](rust-lang/rust#101329) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. - [Add support for linking against macOS universal libraries](rust-lang/rust#98736) Libraries --------- - [Fix `#[derive(Default)]` on a generic `#[default]` enum adding unnecessary `Default` bounds](rust-lang/rust#101040) - [Update to Unicode 15](rust-lang/rust#101821) Stabilized APIs --------------- - [`proc_macro::Span::source_text`](https://doc.rust-lang.org/stable/proc_macro/struct.Span.html#method.source_text) - [`uX::{checked_add_signed, overflowing_add_signed, saturating_add_signed, wrapping_add_signed}`](https://doc.rust-lang.org/stable/std/primitive.u8.html#method.checked_add_signed) - [`iX::{checked_add_unsigned, overflowing_add_unsigned, saturating_add_unsigned, wrapping_add_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_add_unsigned) - [`iX::{checked_sub_unsigned, overflowing_sub_unsigned, saturating_sub_unsigned, wrapping_sub_unsigned}`](https://doc.rust-lang.org/stable/std/primitive.i8.html#method.checked_sub_unsigned) - [`BTreeSet::{first, last, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeSet.html#method.first) - [`BTreeMap::{first_key_value, last_key_value, first_entry, last_entry, pop_first, pop_last}`](https://doc.rust-lang.org/stable/std/collections/struct.BTreeMap.html#method.first_key_value) - [Add `AsFd` implementations for stdio lock types on WASI.](rust-lang/rust#101768) - [`impl TryFrom<Vec<T>> for Box<[T; N]>`](https://doc.rust-lang.org/stable/std/boxed/struct.Box.html#impl-TryFrom%3CVec%3CT%2C%20Global%3E%3E-for-Box%3C%5BT%3B%20N%5D%2C%20Global%3E) - [`core::hint::black_box`](https://doc.rust-lang.org/stable/std/hint/fn.black_box.html) - [`Duration::try_from_secs_{f32,f64}`](https://doc.rust-lang.org/stable/std/time/struct.Duration.html#method.try_from_secs_f32) - [`Option::unzip`](https://doc.rust-lang.org/stable/std/option/enum.Option.html#method.unzip) - [`std::os::fd`](https://doc.rust-lang.org/stable/std/os/fd/index.html) Rustdoc ------- - [Add Rustdoc warning for invalid HTML tags in the documentation](rust-lang/rust#101720) Cargo ----- - [Added `cargo remove` to remove dependencies from Cargo.toml](https://doc.rust-lang.org/nightly/cargo/commands/cargo-remove.html) - [`cargo publish` now waits for the new version to be downloadable before exiting](rust-lang/cargo#11062) See [detailed release notes](https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-166-2022-12-15) for more. Compatibility Notes ------------------- - [Only apply `ProceduralMasquerade` hack to older versions of `rental`](rust-lang/rust#94063) - [Don't export `__heap_base` and `__data_end` on wasm32-wasi.](rust-lang/rust#102385) - [Don't export `__wasm_init_memory` on WebAssembly.](rust-lang/rust#102426) - [Only export `__tls_*` on wasm32-unknown-unknown.](rust-lang/rust#102440) - [Don't link to `libresolv` in libstd on Darwin](rust-lang/rust#102766) - [Update libstd's libc to 0.2.135 (to make `libstd` no longer pull in `libiconv.dylib` on Darwin)](rust-lang/rust#103277) - [Opaque types no longer imply lifetime bounds](rust-lang/rust#95474) This is a soundness fix which may break code that was erroneously relying on this behavior. - [Make `order_dependent_trait_objects` show up in future-breakage reports](rust-lang/rust#102635) - [Change std::process::Command spawning to default to inheriting the parent's signal mask](rust-lang/rust#101077) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Enable BOLT for LLVM compilation](rust-lang/rust#94381) - [Enable LTO for rustc_driver.so](rust-lang/rust#101403) Version 1.65.0 (2022-11-03) ========================== Language -------- - [Error on `as` casts of enums with `#[non_exhaustive]` variants] (rust-lang/rust#92744) - [Stabilize `let else`](rust-lang/rust#93628) - [Stabilize generic associated types (GATs)] (rust-lang/rust#96709) - [Add lints `let_underscore_drop`, `let_underscore_lock`, and `let_underscore_must_use` from Clippy] (rust-lang/rust#97739) - [Stabilize `break`ing from arbitrary labeled blocks ("label-break-value")] (rust-lang/rust#99332) - [Uninitialized integers, floats, and raw pointers are now considered immediate UB](rust-lang/rust#98919). Usage of `MaybeUninit` is the correct way to work with uninitialized memory. - [Stabilize raw-dylib for Windows x86_64, aarch64, and thumbv7a] (rust-lang/rust#99916) - [Do not allow `Drop` impl on foreign ADTs] (rust-lang/rust#99576) Compiler -------- - [Stabilize -Csplit-debuginfo on Linux] (rust-lang/rust#98051) - [Use niche-filling optimization even when multiple variants have data] (rust-lang/rust#94075) - [Associated type projections are now verified to be well-formed prior to resolving the underlying type] (rust-lang/rust#99217) - [Stringify non-shorthand visibility correctly] (rust-lang/rust#100350) - [Normalize struct field types when unsizing] (rust-lang/rust#101831) - [Update to LLVM 15](rust-lang/rust#99464) - [Fix aarch64 call abi to correctly zeroext when needed] (rust-lang/rust#97800) - [debuginfo: Generalize C++-like encoding for enums] (rust-lang/rust#98393) - [Add `special_module_name` lint] (rust-lang/rust#94467) - [Add support for generating unique profraw files by default when using `-C instrument-coverage`] (rust-lang/rust#100384) - [Allow dynamic linking for iOS/tvOS targets] (rust-lang/rust#100636) New targets: - [Add armv4t-none-eabi as a tier 3 target] (rust-lang/rust#100244) - [Add powerpc64-unknown-openbsd and riscv64-unknown-openbsd as tier 3 targets] (rust-lang/rust#101025) - Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Don't generate `PartialEq::ne` in derive(PartialEq)] (rust-lang/rust#98655) - [Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default] (rust-lang/rust#101325) - [Forbid mixing `System` with direct system allocator calls] (rust-lang/rust#101394) - [Document no support for writing to non-blocking stdio/stderr] (rust-lang/rust#101416) - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`](rust-lang/rust#95295) This also changes the safety conditions on `Layout::from_size_align_unchecked`. Stabilized APIs --------------- - [`std::backtrace::Backtrace`] (https://doc.rust-lang.org/stable/std/backtrace/struct.Backtrace.html) - [`Bound::as_ref`] (https://doc.rust-lang.org/stable/std/ops/enum.Bound.html#method.as_ref) - [`std::io::read_to_string`] (https://doc.rust-lang.org/stable/std/io/fn.read_to_string.html) - [`<*const T>::cast_mut`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_mut) - [`<*mut T>::cast_const`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.cast_const) These APIs are now stable in const contexts: - [`<*const T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) - [`<*mut T>::offset_from`] (https://doc.rust-lang.org/stable/std/primitive.pointer.html#method.offset_from) Cargo ----- - [Apply GitHub fast path even for partial hashes] (rust-lang/cargo#10807) - [Do not add home bin path to PATH if it's already there] (rust-lang/cargo#11023) - [Take priority into account within the pending queue] (rust-lang/cargo#11032). This slightly optimizes job scheduling by Cargo, with typically small improvements on larger crate graph builds. Compatibility Notes ------------------- - [`std::layout::Layout` size must not overflow `isize::MAX` when rounded up to `align`] (rust-lang/rust#95295). This also changes the safety conditions on `Layout::from_size_align_unchecked`. - [`PollFn` now only implements `Unpin` if the closure is `Unpin`] (rust-lang/rust#102737). This is a possible breaking change if users were relying on the blanket unpin implementation. See discussion on the PR for details of why this change was made. - [Drop ExactSizeIterator impl from std::char::EscapeAscii] (rust-lang/rust#99880) This is a backwards-incompatible change to the standard library's surface area, but is unlikely to affect real world usage. - [Do not consider a single repeated lifetime eligible for elision in the return type] (rust-lang/rust#103450) This behavior was unintentionally changed in 1.64.0, and this release reverts that change by making this an error again. - [Reenable disabled early syntax gates as future-incompatibility lints] (rust-lang/rust#99935) - [Update the minimum external LLVM to 13] (rust-lang/rust#100460) - [Don't duplicate file descriptors into stdio fds] (rust-lang/rust#101426) - [Sunset RLS](rust-lang/rust#100863) - [Deny usage of `#![cfg_attr(..., crate_type = ...)]` to set the crate type] (rust-lang/rust#99784) This strengthens the forward compatibility lint deprecated_cfg_attr_crate_type_name to deny. - [`llvm-has-rust-patches` allows setting the build system to treat the LLVM as having Rust-specific patches] (rust-lang/rust#101072) This option may need to be set for distributions that are building Rust with a patched LLVM via `llvm-config`, not the built-in LLVM. Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add `x.sh` and `x.ps1` shell scripts] (rust-lang/rust#99992) - [compiletest: use target cfg instead of hard-coded tables] (rust-lang/rust#100260) - [Use object instead of LLVM for reading bitcode from rlibs] (rust-lang/rust#98100) - [Enable MIR inlining for optimized compilations] (rust-lang/rust#91743) This provides a 3-10% improvement in compiletimes for real world crates. See [perf results] (https://perf.rust-lang.org/compare.html?start=aedf78e56b2279cc869962feac5153b6ba7001ed&end=0075bb4fad68e64b6d1be06bf2db366c30bc75e1&stat=instructions:u).

Set DebuginfoKind::Pdb in msvc_base This PDB setting was added to `windows_msvc_base` in rust-lang/rust#98051. It's also needed for the UEFI targets, and since `uefi_msvc_base` and `windows_msvc_base` are the only things that inherit from `msvc_base`, just move the PDB setting up to `mscv_base` to cover both. Fixes rust-lang/rust#101071

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 13, 2022

rust-highfive assigned jackh726 Jun 13, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2022

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 13, 2022

davidtwco commented Jun 13, 2022

View reviewed changes

wesleywiser reviewed Jun 13, 2022

View reviewed changes

compiler/rustc_target/src/spec/mod.rs Outdated Show resolved Hide resolved

davidtwco force-pushed the split-dwarf-stabilization branch from c3d7a80 to b1ae3b6 Compare June 13, 2022 16:11

This comment was marked as resolved.

Sign in to view

davidtwco force-pushed the split-dwarf-stabilization branch from b1ae3b6 to d295122 Compare July 4, 2022 08:04

This comment was marked as resolved.

Sign in to view

rust-highfive assigned michaelwoerister and unassigned jackh726 Jul 10, 2022

davidtwco force-pushed the split-dwarf-stabilization branch from d295122 to 8a8151c Compare July 11, 2022 07:42

davidtwco mentioned this pull request Jul 13, 2022

1.62.0 build on Solaris fails with - error: -Csplit-debuginfo is unstable on this platfor #99208

Closed

This comment was marked as resolved.

Sign in to view

davidtwco force-pushed the split-dwarf-stabilization branch from 8a8151c to dd7a9b5 Compare July 14, 2022 13:08

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 14, 2022

This comment was marked as resolved.

Sign in to view

davidtwco force-pushed the split-dwarf-stabilization branch from dd7a9b5 to d1746e8 Compare July 15, 2022 08:12

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 19, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 26, 2022

bors merged commit 450e99f into rust-lang:master Aug 26, 2022

rustbot added this to the 1.65.0 milestone Aug 26, 2022

bors mentioned this pull request Aug 26, 2022

rustc_target: Add some more target spec sanity checking #100537

Merged

rustbot added the perf-regression Performance regression. label Aug 26, 2022

nicholasbishop mentioned this pull request Aug 27, 2022

UEFI targets fail to compile: "LLVM ERROR: dwo only supported with ELF and Wasm" #101071

Closed

nicholasbishop mentioned this pull request Aug 27, 2022

Set DebuginfoKind::Pdb in msvc_base #101088

Merged

rustbot removed the perf-regression Performance regression. label Aug 28, 2022

davidtwco deleted the split-dwarf-stabilization branch October 13, 2022 14:22

Gankra mentioned this pull request Oct 24, 2022

Splitting Debuginfo axodotdev/cargo-dist#30

Open

ehuss mentioned this pull request Oct 28, 2022

Update note about unstable split-debuginfo flag. #103674

Merged

skyzh mentioned this pull request Nov 1, 2022

performance regression (for debug & single binary) of backtrace capturing after bumping toolchain on macOS risingwavelabs/risingwave#6131

Closed

jiacai2050 mentioned this pull request Nov 11, 2022

Reduce the binary size of ceresdb-server apache/incubator-horaedb#294

Open

Gankra mentioned this pull request Nov 16, 2022

Register .dwp files as debuginfo artifacts so they get uplifted rust-lang/cargo#11384

Closed

wesleywiser mentioned this pull request Jan 5, 2024

debuginfo: Add support for split-debuginfo on platforms that allow it #34651

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

session: stabilize split debuginfo on linux #98051

session: stabilize split debuginfo on linux #98051

davidtwco commented Jun 13, 2022 •

edited

rust-highfive commented Jun 13, 2022

rust-highfive commented Jun 13, 2022

davidtwco commented Jun 13, 2022 •

edited

rfcbot commented Jun 13, 2022 •

edited by petrochenkov

davidtwco Jun 13, 2022

michaelwoerister Aug 3, 2022

davidtwco Aug 9, 2022

davidtwco Aug 9, 2022

michaelwoerister commented Jul 1, 2022

This comment was marked as resolved.

michaelwoerister commented Jul 6, 2022

This comment was marked as resolved.

jackh726 commented Jul 10, 2022

This comment was marked as resolved.

This comment was marked as resolved.

rfcbot commented Jul 19, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

rust-timer commented Aug 26, 2022

lqd commented Aug 26, 2022

nnethercote commented Aug 28, 2022

nnethercote commented Aug 28, 2022

session: stabilize split debuginfo on linux #98051

session: stabilize split debuginfo on linux #98051

Conversation

davidtwco commented Jun 13, 2022 • edited

rust-highfive commented Jun 13, 2022

rust-highfive commented Jun 13, 2022

davidtwco commented Jun 13, 2022 • edited

Stabilization report

Brief summary

Implementation History

Open issues

rfcbot commented Jun 13, 2022 • edited by petrochenkov

davidtwco Jun 13, 2022

Choose a reason for hiding this comment

michaelwoerister Aug 3, 2022

Choose a reason for hiding this comment

davidtwco Aug 9, 2022

Choose a reason for hiding this comment

davidtwco Aug 9, 2022

Choose a reason for hiding this comment

michaelwoerister commented Jul 1, 2022

This comment was marked as resolved.

michaelwoerister commented Jul 6, 2022

This comment was marked as resolved.

jackh726 commented Jul 10, 2022

This comment was marked as resolved.

This comment was marked as resolved.

rfcbot commented Jul 19, 2022

bors commented Aug 26, 2022

bors commented Aug 26, 2022

rust-timer commented Aug 26, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

lqd commented Aug 26, 2022

nnethercote commented Aug 28, 2022

nnethercote commented Aug 28, 2022

davidtwco commented Jun 13, 2022 •

edited

davidtwco commented Jun 13, 2022 •

edited

rfcbot commented Jun 13, 2022 •

edited by petrochenkov