Migrate some rustc_borrowck diagnostics to SessionDiagnostic
#98415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Jun 23, 2022
| @@ -10,7 +10,7 @@ LL | | .into_iter() | |||
| LL | | .map(|elem| elem.to_string()) | |||
| | |_____________________________________^ | |||
| | | |||
| = note: could not prove for<'r> [closure@$DIR/issue-71546.rs:14:14: 14:37] well-formed | |||
| = note: could not prove `for<'r> [closure@$DIR/issue-71546.rs:14:14: 14:37] well-formed` | |||
There was a problem hiding this comment.
The Display impl for Predicate means that we either put ticks around this or we don't put ticks around "could not prove Ty: Trait" -- I prefer the backticks around all predicates.
We could perhaps also avoid this by having Predicate have a smarter Display impl, or maybe having a special IntoDiagnosticArg for Predicate.
There was a problem hiding this comment.
It's a little unfortunate that "well-formed" is also in the backticks but I think this is probably fine for now.
davidtwco
approved these changes
Jun 23, 2022
|
@bors r+ rollup |
|
📌 Commit 621811447b06188833bf81f88dd9c5b1eba4b95e has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
@bors r- failed to merge apparently |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #98438) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
rustc-borrowck-session-diagnostic-1
branch
from
6218114
to
98af1bf
Compare
|
@bors r=davidtwco |
|
📌 Commit 98af1bf has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 29, 2022
…ion-diagnostic-1, r=davidtwco Migrate some `rustc_borrowck` diagnostics to `SessionDiagnostic` Self-explanatory r? `@davidtwco`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 29, 2022
…ion-diagnostic-1, r=davidtwco Migrate some `rustc_borrowck` diagnostics to `SessionDiagnostic` Self-explanatory r? ``@davidtwco``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#98415 (Migrate some `rustc_borrowck` diagnostics to `SessionDiagnostic`) - rust-lang#98479 (Add `fetch_not` method on `AtomicBool`) - rust-lang#98499 (Erase regions in New Abstract Consts) - rust-lang#98516 (library: fix uefi va_list type definition) - rust-lang#98554 (Fix box with custom allocator in miri) - rust-lang#98607 (Clean up arg mismatch diagnostic, generalize tuple wrap suggestion) - rust-lang#98625 (emit Retag for compound types with reference fields) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
davidtwco
added
the
A-translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory
r? @davidtwco