New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
99522 more semicolon hint #99622
99522 more semicolon hint #99622
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
@estebank (since you're marked as reviewer) I'm stuck here, if you have any guidance I'm interested 😅 (but it's not urgent, don't worry !) |
Ideally, you would need access to the underlying expression. I think you could optionally pass one in from (likely) |
cca9623
to
c7f4eaa
Compare
Thanks for the help ! It's much better now but I have duplicated diagnostics in the
Edit:
|
This comment has been minimized.
This comment has been minimized.
c7f4eaa
to
d647e4a
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Can you add a test file and run |
Hm, my change suggests to add a async fn caller() {
dummy() // suggest `;` here (.await is also suggested)
}
async fn dummy() {} This is not incorrect, but probably not what the user wanted to do at all, and it distracts from the |
Closing since relevant issue has been closed |
This change works perfectly well for the code in
main
but it suggests an erroneous change fortest_error
and I don't know how to fix it.Suggestions: