Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #99722

Merged
merged 1 commit into from
Jul 25, 2022
Merged

update Miri #99722

merged 1 commit into from
Jul 25, 2022

Conversation

RalfJung
Copy link
Member

Fixes #99664
r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Jul 25, 2022

The Miri submodule was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r= p=1

@bors
Copy link
Contributor

bors commented Jul 25, 2022

📌 Commit 606924d has been approved by ``

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 25, 2022
@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jul 25, 2022

📌 Commit 606924d has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 25, 2022

⌛ Testing commit 606924d with merge bdf520f...

@bors
Copy link
Contributor

bors commented Jul 25, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing bdf520f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2022
@bors bors merged commit bdf520f into rust-lang:master Jul 25, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 25, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #99722!

Tested on commit bdf520f.
Direct link to PR: #99722

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 25, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#99722!
da24f42 
Tested on commit rust-lang/rust@bdf520f.
Direct link to PR: <rust-lang/rust#99722>

🎉 miri on windows: build-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: build-fail → test-pass (cc @oli-obk @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bdf520f): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.2% -2.4% 2
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@RalfJung RalfJung deleted the miri branch July 27, 2022 01:39
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 28, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#98674
5 participants
@RalfJung @rustbot @bors @rust-highfive @rust-timer