Link to internal rustdocs#100 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
requested changes
Apr 5, 2018
src/appendix-stupid-stats.md
Outdated
| @@ -87,7 +87,7 @@ in [librustc_back](https://github.com/rust-lang/rust/tree/master/src/librustc_ba | |||
| (which also contains some things used primarily during translation). | |||
|
|
|||
| All these phases are coordinated by the driver. To see the exact sequence, look | |||
| at the `compile_input` function in [librustc_driver/driver.rs](https://github.com/rust-lang/rust/tree/master/src/librustc_driver/driver.rs). | |||
| at the `compile_input` function in [librustc_driver/driver.rs](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_driver/driver/). | |||
There was a problem hiding this comment.
Let's link directly to the function:
https://doc.rust-lang.org/nightly/nightly-rustc/rustc_driver/driver/fn.compile_input.html
|
Thank you for starting on this! Super exciting. |
nikomatsakis
approved these changes
Apr 5, 2018
|
I went ahead and adjusted my nit. =) Assuming travis is happy, will merge. |
|
A couple of offending long lines:
|
rajcspsg
force-pushed
the
link_to_rustdocs#100
branch
2 times, most recently
from
9bdf929
to
70f3c27
Compare
rajcspsg
force-pushed
the
link_to_rustdocs#100
branch
from
70f3c27
to
a5dd5de
Compare
rajcspsg
commented
Apr 5, 2018
| To create a drop-in compiler replacement or a compiler replacement, | ||
| we leave most of compilation alone and customise the driver using its APIs. | ||
|
|
||
| [compile-input]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_driver/driver/fn.compile_input.html | ||
|
|
There was a problem hiding this comment.
@mark-i-m @nikomatsakis Please let me know if these changes looks fine.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #100 @mark-i-m @Michael-F-Bryan