Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to mdbook 0.2 #184

Merged
merged 10 commits into from
Sep 21, 2018
Merged

Update to mdbook 0.2 #184

merged 10 commits into from
Sep 21, 2018

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Aug 20, 2018

fixes #172, fixes #109

Dropped travis caches...

Currently it looks like linkcheck is passing despite broken links?

r? @Michael-F-Bryan

@Michael-F-Bryan
Copy link
Contributor

@mark-i-m v0.2.1 is on crates.io so it looks like this PR should be unblocked now. Don't forget that you can enable checking remote links or going outside the book root via the config file.

@Michael-F-Bryan
Copy link
Contributor

@mark-i-m, it looks like the crates.io link is still getting a 404 and making travis fail. This is probably related to rust-lang/crates.io#788, but should I add some sort of exclude option to mdbook-linkcheck?

@mark-i-m
Copy link
Member Author

@Michael-F-Bryan Yes, a whitelist would be really useful. For now, I can just disable external link checking (unfortunately, that would also disabled checking links to compiler rustdocs), unless it would be a fast change.

@Michael-F-Bryan
Copy link
Contributor

@mark-i-m I've uploaded a new release of mdbook-linkcheck. You should be able to skip false-positive URLs by adding a list of excluded URL patterns to your book.toml.

[output.linkcheck]
follow-web-links = true
exclude = [ "crates\\.io" ]

@mark-i-m
Copy link
Member Author

🎉 🎉 🎉 Finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar subsection titles are cut-off Links don't work on github
2 participants