Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken hyperlink #862

Merged
merged 3 commits into from Sep 9, 2020
Merged

Fix broken hyperlink #862

merged 3 commits into from Sep 9, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Sep 9, 2020

@jyn514 jyn514 added the waiting-on-review This PR is waiting for a reviewer to verify its content label Sep 9, 2020
@nico-abram
Copy link
Contributor

This fixes the broken link, but it still seems slightly confusing to me

The paragraph says:

As documented above, this will build a functional stage1 compiler as part of running all stage0 commands (which include building a std compatible with the stage1 compiler) as well as the first few steps of the "stage 1 actions" up to "stage1 (sysroot stage1) builds std".

But there is no mention of stage1 or 0 in the linked-to section, and also no mention of "-i"

@jyn514
Copy link
Member Author

jyn514 commented Sep 9, 2020

Hmm, maybe it would be better to link to https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html#stages-of-bootstrapping instead?

@nico-abram
Copy link
Contributor

Maybe. I'm not sure skipping ahead to the next chapter would be better, and this is certainly better than the broken link. Anyone curious will probably keep on reading and reach the next chapter

@jyn514
Copy link
Member Author

jyn514 commented Sep 9, 2020

Actually https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html#building-the-compiler is probably a better place, let me try that.

@nico-abram
Copy link
Contributor

That seems perfect to me, it's behind and more or less explains both -i and --stage

@jyn514
Copy link
Member Author

jyn514 commented Sep 9, 2020

Awesome, thanks for the review!

r? @spastorino to double check I didn't miss a typo

@spastorino spastorino merged commit b29062c into rust-lang:master Sep 9, 2020
@jyn514 jyn514 deleted the links branch September 9, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-review This PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants