Skip to content

Commit

Permalink
Move new errors message to summary
Browse files Browse the repository at this point in the history
  • Loading branch information
Mark-Simulacrum committed Feb 8, 2022
1 parent 0dd5562 commit 752e896
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions site/src/comparison.rs
Original file line number Diff line number Diff line change
Expand Up @@ -368,20 +368,6 @@ impl ComparisonSummary {

self.write_summary_lines(&mut result, Some(link));

if !comparison.new_errors.is_empty() {
write!(
result,
"- New errors in {}",
comparison
.new_errors
.keys()
.map(|k| k.as_str())
.collect::<Vec<_>>()
.join(", ")
)
.unwrap();
}

result
}

Expand All @@ -407,6 +393,20 @@ impl ComparisonSummary {
write!(result, "- ").unwrap();
change.summary_line(result, link)
}

if !comparison.new_errors.is_empty() {
write!(
result,
"- Benchmarks {} started failing to build",
comparison
.new_errors
.keys()
.map(|k| k.as_str())
.collect::<Vec<_>>()
.join(", ")
)
.unwrap();
}
}
}

Expand Down

0 comments on commit 752e896

Please sign in to comment.