Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for downloading a new benchmark #1183

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 25, 2022

Inspired by Zulip conversion between @nnethercote and @Mark-Simulacrum.
Usage:

$ ./collector download crate syn 1.0.0 --name syn2
$ ./collector download git https://github.com/dtolnay/syn

collector/src/main.rs Outdated Show resolved Hide resolved
@nnethercote
Copy link
Contributor

Is it necessary to be able to get the crate by cloning from github? That's what I was doing and this morning @lqd explained how to download from crates.io and my experience so far is that the crates.io way is simpler and less error-prone.

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 25, 2022

Sure, but I suppose that not all crates are on crates.io? For example people that create performance regression issues on the rustc repository often link their github repo.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 2, 2022

I changed the logic to guess the unpacked package name and added a comment.

@nnethercote
Copy link
Contributor

It occurs to me that if #1181 is going to require a primary or secondary entry in the perf-config.json, then this command should probably create that file. Possibly requiring primary or secondary as an additional argument. If this is merged first, I guess that could be added in #1183.

@Mark-Simulacrum
Copy link
Member

Yeah, I agree that creating that file would be good.

I'm not sure why CI is failing, but that seems like the main blocker left here.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 2, 2022

@nnethercote You are completely right :) I just didn't add it here since I wasn't sure which PR would get merged first.

CI seems broken since some package is missing, I'm not sure if its transient or not 🤷 Maybe the workflow will need updating.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 3, 2022

The package still returns 404, so we might need to update package versions on CI.

@Kobzol
Copy link
Contributor Author

Kobzol commented Mar 4, 2022

Rebased over master with fixed CI.

@Kobzol Kobzol requested a review from nnethercote March 4, 2022 12:06
collector/src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@nnethercote nnethercote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor suggestions.

@nnethercote nnethercote merged commit 1e8322f into rust-lang:master Mar 7, 2022
@Kobzol Kobzol deleted the download-command branch March 7, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants