Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid common failure modes #752

Closed
wants to merge 2 commits into from

Conversation

Mark-Simulacrum
Copy link
Member

This changes two things that @jonas-schievink hit recently:

  • Changes the default to replacing, rather than appending to existing collected data (on CI, we still append)
  • Adds the default database path to the server, matching the collector.

This prevents the (possibly) common failure mode of choosing a different
database file by mistake locally.
This avoids the semi-common annoyance that you need to choose unique IDs for
each local run.
@Mark-Simulacrum
Copy link
Member Author

Mark-Simulacrum commented Aug 25, 2020

One detail pointed out on Zulip is that if we by default overwrite, the chances of deleting just-collected data are pretty high. It's not entirely clear what a good solution is yet, though.

@jyn514
Copy link
Member

jyn514 commented Dec 1, 2020

I would be happy with a way to opt-in to overwrite, instead of making it the default. Right now the only way to do that is to manually mess with the sqlite database.

@rylev
Copy link
Member

rylev commented Jul 9, 2021

Going to close since this is a bit stale. Feel free to reopen if you'd like to continue working on this (or if you think this should be rebased and re-reviewed).

@rylev rylev closed this Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants