Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't force a newline after an empty where clause (master) #4557

Merged
merged 1 commit into from
Dec 9, 2020
Merged

fix: don't force a newline after an empty where clause (master) #4557

merged 1 commit into from
Dec 9, 2020

Conversation

meiomorphism
Copy link
Contributor

Rebase of #4548 onto master. Clean.

@meiomorphism
Copy link
Contributor Author

I've looked at several of the CI failures; they all seem to be from rustc-ap-rustc_data_structures-686.0.0, due to the recent rename of the optin_builtin_traits feature to auto_traits (rust-lang/rust@810324d).

Presumably updating to 690.0.0 will fix that.

@calebcartwright
Copy link
Member

Don't worry about the broken CI for now, it's a broken toolstate issue - rust-lang/rust#79407

@calebcartwright
Copy link
Member

When you get a chance could you rebase on master? CI checks should be good now

@meiomorphism
Copy link
Contributor Author

Pinging, since I've forgotten whether GitHub pings on branch updates, and now suspect that it doesn't.

@calebcartwright
Copy link
Member

Pinging, since I've forgotten whether GitHub pings on branch updates, and now suspect that it doesn't.

Thanks. I believe it does, at least for non-rebases, but also entirely possible that I missed this one amongst the notification noise

@karyon
Copy link
Contributor

karyon commented Oct 27, 2021

backported in #4548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants