rustfmt no longer builds after rust-lang/rust#79336

[rust-highfive]

Hello, this is your friendly neighborhood mergebot.
After merging PR #79336, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @camelid, do you think you would have time to do the follow-up work?
If so, that would be great!

[camelid]

Huh, how did this PR break rustfmt? ripgrep doesn't show any use of optin_builtin_traits, and it compiled fine locally.

[camelid]

Do I need to wait until there's a nightly with the changes or something?

[camelid]

I think this is the same problem as in #79406. I think this might be a little too beyond my understanding of how to fix for now, so I'm unassigning myself.

[calebcartwright]

@camelid - rustfmt leverages the internal rustc mods via the auto publish crates process since rustfmt itself is also published to crates.io. As such the version of those rustc mods used within the rustfmt dep tree tend to lag at least a few weeks behind and in broken toolstate cases like this the fix almost always entails updating those crate versions and dealing with all the subsequent fall out of rustc changes within the rustfmt codebase.

I was already in the process of working on such a bump of those crates, so will hopefully have a fix out before too long (though there were some breaking changes in the parser I need to dig into first)

[calebcartwright]

We'll need a new rustc-ap version to address this

At a minimum the steps will include:

• (1) Land rustc_parse: restore public visibility on parse_attribute #79433
• (2) get new versions of rustc-ap crates published (will be v691), next scheduled run is next Tuesday morning, December 1st (early publish triggered - include crate links alexcrichton/rustc-auto-publish#27)
• (3) bump rustc-ap* in racer and publish new version on crates.io (deps: bump rustc-ap to v691 racer-rust/racer#1143)
• (3) bump rustc-ap* on rustfmt 1.4.29 branch and publish new version on crates.io ([1.x] Bump rustc-ap crates rustfmt#4561)
• (4) update racer and rustfmt references in rls
• (5) update rustfmt and rls submods in rust-lang/rust repo

Note that the rustc-ap bumps in racer and rustfmt can be done in parallel (step 3's), the other tasks all have to be sequenced

[camelid]

next scheduled run is next Tuesday morning, November 1st

I'm assuming you mean December 1st?

[calebcartwright]

I'm assuming you mean December 1st?

Indeed thank you. Bad copy/pasta job

[camelid]

Bad copy/pasta job

You're making me hungry ;) 🍝

[Xanewok]

@calebcartwright Racer is updated and published as v2.1.41. Should we wait until rustfmt-nightly is released or should I already bump versions in RLS?

[calebcartwright]

@Xanewok - I'm actually going to cut a v1.4.29 release for rustfmt that contains some additional things we were able to get merged in the interim. Unfortunately I still don't have access to publish to crates, but will send a PR to RLS with the bumps after i finish in the rustfmt repo