Fix/comments inside trait generics gets duplicated #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmj0502
changed the title
ytmimi
reviewed
Jul 17, 2022
tests/target/issue-5358.rs
Outdated
| @@ -0,0 +1,4 @@ | |||
| // Test /* comment */ inside trait generics gets duplicated. | |||
There was a problem hiding this comment.
Should this read Test /* comment */ inside trait generics does not get duplicated?
There was a problem hiding this comment.
Yes! I'll fix it un a few minutes.
ytmimi
approved these changes
Jul 17, 2022
ytmimi
force-pushed
the
fix/comments-inside-trait-generics-gets-duplicated
branch
from
4e23b41
to
a17dfb2
Compare
ytmimi
force-pushed
the
fix/comments-inside-trait-generics-gets-duplicated
branch
from
a17dfb2
to
2ce5697
Compare
ytmimi
added
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5358
comment_hiis equals to thegeneric.span.loif there actually are any generic parameters, otherwise it will kept the value previously defined.