Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: pin a version of markedjs from cdnjs #6194

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Jun 13, 2024

Hi! It seems like the docs site is currently broken. Previous to this commit, the cdn markedjs url was not versioned, so when markedjs v13 introduced breaking changes on 2024-06-12, the rustfmt docs site automatically pulled them in.

In addition to fixing that problem by pinning to v12, this PR:

  • Expands the cdnjs links and script tags to reflect their recommendations, including an integrity hash so the browser can check that the retrieved executable content is in fact as-expected.
  • Switches markedjs and vue from jsdelivr to cdnjs, which should be slightly faster as the browser already will have a reusable http/tls connection to cdnjs from other resources.
  • Uses the minified vue file, silencing a warning that vue was being used in development mode.

However, this PR does not change the versions of any dependencies, many of which are significantly out of date.

Thanks!

@ian-h-chamberlain
Copy link

@ytmimi thanks for the quick response, just confirming these changes do in fact resolve the problem for me (tested on Firefox 127.0 and Safari 17.5).

Seems like this change would help prevent future similar breakages from upstream too! 👍

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and detailed explanations!

@calebcartwright calebcartwright merged commit 55a7026 into rust-lang:master Jun 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants