impl rewrite_result for Pat, TuplePatField #6262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
ytmimi
reviewed
Aug 4, 2024
ytmimi
approved these changes
Aug 4, 2024
ding-young
force-pushed
the
rw-result-pat
branch
from
fafdb34
to
04b0479
Compare
- also update rewrite_unary_*** to return RewriteResult
ding-young
force-pushed
the
rw-result-pat
branch
from
04b0479
to
7bc4c48
Compare
ding-young
commented
Aug 5, 2024
Comment on lines
+1997
to
+1999
| let shape = shape | ||
| .sub_width(suffix.len()) | ||
| .max_width_error(shape.width, rewrite.span())?; |
There was a problem hiding this comment.
@ytmimi Thank you! I addressed the nit, and rebased it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by #6206
Description
Pat,TuplePatFieldrewrite_unary_***to returnRewriteResult