Skip to content

Commit

Permalink
fix: use trait objects for from_str
Browse files Browse the repository at this point in the history
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate 
errors.
  • Loading branch information
tlyu committed Apr 4, 2021
1 parent 2e93a58 commit c3e7b83
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion exercises/conversions/from_str.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Additionally, upon implementing FromStr, you can use the `parse` method
// on strings to generate an object of the implementor type.
// You can read more about it at https://doc.rust-lang.org/std/str/trait.FromStr.html
use std::error;
use std::str::FromStr;

#[derive(Debug)]
Expand All @@ -23,7 +24,7 @@ struct Person {
// If everything goes well, then return a Result of a Person object

impl FromStr for Person {
type Err = String;
type Err = Box<dyn error::Error>;
fn from_str(s: &str) -> Result<Person, Self::Err> {
}
}
Expand Down
2 changes: 1 addition & 1 deletion info.toml
Original file line number Diff line number Diff line change
Expand Up @@ -884,5 +884,5 @@ path = "exercises/conversions/from_str.rs"
mode = "test"
hint = """
The implementation of FromStr should return an Ok with a Person object,
or an Err with a string if the string is not valid.
or an Err with an error if the string is not valid.
This is almost like the `try_from_into` exercise."""

0 comments on commit c3e7b83

Please sign in to comment.