Remove duplicate not done comment #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated in rust-lang#259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from rust-lang#281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
|
IMO the comment should be moved into the block above |
|
I choose the bottom one 'cause it was closer to the code I was editing ( I used vim, hence easier to spot ), but I'll switch to the comment on top if that's the convention |
|
@Tuxified that sounds good! |
|
Ok, I made the switch to remove the bottom one. Any other remarks/questions ? Do you agree with this change ? |
shadows-withal
approved these changes
Apr 8, 2020
pedantic79
pushed a commit
to pedantic79/rustlings
that referenced
this pull request
Apr 11, 2020
Remove duplicate not done comment
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
Remove duplicate not done comment
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Remove duplicate not done comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in #259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from #281 to remove a comment and use
:wnto go to next exercise, hence this tripped me).