Watch for file creation events in watch mode #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komaeda
approved these changes
Mar 6, 2019
|
thanks for your contribution! ❤️ |
pedantic79
pushed a commit
to pedantic79/rustlings
that referenced
this pull request
Apr 11, 2020
Watch for file creation events in watch mode
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
Watch for file creation events in watch mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently watch mode only watches for
DebouncedEvent::ChmodandDebouncedEvent::Write. There are some edge cases where these events wont be called even when a file is modified.For example, if the user is using vim with swap files enabled, it seems like only a
Removeand thenCreateevent is called for the rust file. Usually this is okay because there will also be a swp file being modified, but if the user has their swap files placed in a different directory,rustlings watchdoes not work.This fixes the issue by also listening for the
Createevent, and only triggering for .rs files (so swp file changes are ignored).I'm guessing that this may be related to #111, as I ran into the same issue and started looking into why watch wasn't working.