Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added exercise to "traits" chapter #1472

Closed
wants to merge 3 commits into from

Conversation

abhi3700
Copy link

@abhi3700 abhi3700 commented Apr 7, 2023

This is an attempt to add 1 exercise in "traits" chapter.

The objective is to let the developer learn these:

  • "How to implement at function that can return incompatible types?"
  • "How to make the same function printable on console?"

Looking forward to getting feedback on this.

@poneciak57
Copy link
Contributor

Exercise traits6 is unnecessarily large, tests seems redundant here.

@abhi3700
Copy link
Author

abhi3700 commented Apr 7, 2023

Exercise traits6 is unnecessarily large, tests seems redundant here.

I can add ?? in tests.

Or I just have only ‘traits7.rs’

@poneciak57
Copy link
Contributor

I think u can just delete tests and add main function with simple showcase.

@abhi3700
Copy link
Author

abhi3700 commented Apr 8, 2023

I think u can just delete tests and add main function with simple showcase.

ok followed

@abhi3700 abhi3700 changed the title feature: added exercises to "traits" chapter feature: added exercise to "traits" chapter Apr 8, 2023
@abhi3700
Copy link
Author

abhi3700 commented Jun 6, 2023

Can this be merged?

@shadows-withal
Copy link
Member

This seems to me like too much of a jump between complexity in exercises (e.g. I don't think we should be touching dyn at this point, or Box before the exercise in which it's introduced).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants