Adds a simple exercise for structures #163

briankung · 2019-05-25T11:41:17Z

Thanks for rustlings! Here's a small contribution in return.

komaeda

thank you!

komaeda · 2019-05-25T13:40:12Z

@bors r+

bors · 2019-05-25T13:40:13Z

📌 Commit 9b92aa0 has been approved by komaeda

bors · 2019-05-25T13:40:21Z

⌛ Testing commit 9b92aa0 with merge 1f07fd4...

Adds a simple exercise for structures Thanks for rustlings! Here's a small contribution in return.

bors · 2019-05-25T14:00:11Z

☀️ Test successful - checks-travis
Approved by: komaeda
Pushing 1f07fd4 to master...

edmundmiller · 2019-06-10T17:55:39Z

I'm having an issue with this. I'm not sure if correct answers should be discussed here or not. It may also be because of my lack of experience.

    #[test]
    fn unit_structs() {
        // TODO: Instantiate a unit struct!
        let green = ColorUnitStruct;

        if let ColorUnitStruct = green {
            assert!(true);
        } else {
            assert!(false);
        }
    }

Results in

error[E0162]: irrefutable if-let pattern
  --> exercises/structs/structs1.rs:41:16
   |
41 |         if let ColorUnitStruct = green {
   |                ^^^^^^^^^^^^^^^ irrefutable pattern

briankung · 2019-06-11T21:05:39Z

@emiller88 would you mind sharing that entire test?

edmundmiller · 2019-06-11T21:18:10Z

@briankung Sorry I should have mentioned it's in the exercises/structs/structs1.rs file
https://github.com/briankung/rustlings/blob/9b92aa08aead17d7737137f1c5c382548797b83e/exercises/structs/structs1.rs

briankung · 2019-06-11T21:38:04Z

@emiller88 I understand, sorry I must have had a brain fart (or there was an edit to your comment) but I didn't think I had the entirety of your failing test case. What version of Rust are you using?

edmundmiller · 2019-06-11T21:46:30Z

@briankung rustc 1.32.0-nightly (14997d56a 2018-12-05)

briankung · 2019-06-11T22:11:28Z

Weird. Well, seeing as I'm a Rust newbie myself, I can't really say why this doesn't work on your machine. It does seem to make sense - after all once it knows the type of green, it will always match.

You can try throwing a #[allow(irrefutable_let_patterns)] at the top of the test function. Just to be clear, are you using $ rustlings run exercises/structs/struct1.rs to run this? And have you run the rustlings command on other exercises? For whatever reason, it seems to allow irrefutable let patterns by default for me (rustc 1.37.0-nightly (02564de47 2019-06-10)) as well as dead code in a bunch of exercises.

edmundmiller · 2019-06-11T22:44:34Z

I was using rustlings watch but it doesn't work with rustlings run exercises/structs/struct1.rs either.

#[allow(irrefutable_let_patterns)] doesn't help either.

briankung · 2019-06-11T22:57:14Z

Odd. Unlikely to be related, but what OS are you using? I'm also confused why the allow attribute doesn't work since it works in the playground. And your test looks like the below?

    #[test]
    #[allow(irrefutable_let_patterns)]
    fn unit_structs() {
        // ...
    }

edmundmiller · 2019-06-11T23:09:47Z

Yes it did, the #[allow(irrefutable_let_patterns)] works in the playground however without it the test still fails so I think it's an issue.

briankung · 2019-06-11T23:25:14Z

I can't recreate the error so I can't reliably fix it, but how would you like to proceed?

…

On Tue, Jun 11, 2019, 6:11 PM Edmund Miller ***@***.***> wrote: Yes it did, the #[allow(irrefutable_let_patterns)] works in the playground however without it the test still fails <https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=b94d896c7d1c19918dc58edceae3ff77> so I think it's an issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#163?email_source=notifications&email_token=AAVUNR3PUD5DHTHB3ID6SS3P2AWEDA5CNFSM4HPUOF52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXOYLZI#issuecomment-501056997>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVUNR55ARFSHDPV65DT27LP2AWEDANCNFSM4HPUOF5Q> .

edmundmiller · 2019-06-11T23:44:04Z

Does this playground work for you? It's exactly what's in the exercises/structs/structs1.rs
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=b94d896c7d1c19918dc58edceae3ff77

briankung · 2019-06-11T23:49:28Z

The tests pass with a warning. I think the playground output should not vary by client machine.

…

On Tue, Jun 11, 2019, 6:44 PM Edmund Miller ***@***.***> wrote: Does this playground work for you? It's exactly what's in the exercises/structs/structs1.rs https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=b94d896c7d1c19918dc58edceae3ff77 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#163?email_source=notifications&email_token=AAVUNR23HGCSTIA4DRXTDFLP2A2EVA5CNFSM4HPUOF52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXO2HVY#issuecomment-501064663>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVUNRZKIH2U6MRV657UWMTP2A2EVANCNFSM4HPUOF5Q> .

edmundmiller · 2019-06-12T01:38:24Z

Ah I didn't see it was a warning in the playground. When it runs with a test(At least in my version) the warning turns into an error when the test runs. If it's just unique to my version I think we're good here.

ksceriath · 2019-06-20T11:26:33Z

I am using
rustc 1.32.0 (9fda7c223 2019-01-16)

Facing the same issue as @emiller88 above. This doesn't appear to be machine specific. I feel we should modify the test around this, else 'rustlings watch' will not function.

ksceriath · 2019-06-20T11:34:42Z

This doesn't error after updating to rustc 1.35.0 (3c235d560 2019-05-20)

briankung · 2019-06-20T14:10:43Z

It seems odd that it would error in one but not the other. I think the test should change, it's just especially odd that something like an irrefutable let pattern would change from version to version of Rust.

@ksceriath does the #[allow(irrefutable_let_patterns)] allow it to compile without errors? I think you can use this snippet to override the toolchain in a particular directory:

$ rustup override set 1.32.0

From: https://doc.rust-lang.org/stable/edition-guide/rust-2018/rustup-for-managing-rust-versions.html#managing-versions)

I'm trying it myself, as well. Hopefully it does the same for rustlings.

briankung · 2019-06-20T15:02:04Z

@emiller88 and @ksceriath I've opened #179, please take a look and see if those changes work for you. Sorry for the inconvenience!

…r=komaeda Fixes the irrefutable let pattern warning in `structs1.rs` PR #163 accidentally introduced an error using some versions of the Rust compiler where the compiler would (rightly!) complain about an irrefutable let pattern. I have no idea why this did not occur in all versions of the compiler, but here is a way around it.

ksceriath · 2019-06-20T16:12:42Z

@briankung This works with 1.32 / 1.35. Thank you!

edmundmiller · 2019-06-20T22:07:52Z

@briankung Works on both for me as well thanks for fixing it!

extrawurst · 2019-07-06T18:02:54Z

going through the tests one by one, i am wondering why this is the first that has no help to scroll down to. even the link to the docs makes this exercise suddenly much harder than the previous

…r=komaeda Fixes the irrefutable let pattern warning in `structs1.rs` PR rust-lang/rustlings#163 accidentally introduced an error using some versions of the Rust compiler where the compiler would (rightly!) complain about an irrefutable let pattern. I have no idea why this did not occur in all versions of the compiler, but here is a way around it.

Adds a simple exercise for structures Thanks for rustlings! Here's a small contribution in return.

…r=komaeda Fixes the irrefutable let pattern warning in `structs1.rs` PR rust-lang/rustlings#163 accidentally introduced an error using some versions of the Rust compiler where the compiler would (rightly!) complain about an irrefutable let pattern. I have no idea why this did not occur in all versions of the compiler, but here is a way around it.

Adds a simple exercise for structures Thanks for rustlings! Here's a small contribution in return.

…tructs1, r=komaeda Fixes the irrefutable let pattern warning in `structs1.rs` PR rust-lang#163 accidentally introduced an error using some versions of the Rust compiler where the compiler would (rightly!) complain about an irrefutable let pattern. I have no idea why this did not occur in all versions of the compiler, but here is a way around it.

…r=komaeda Fixes the irrefutable let pattern warning in `structs1.rs` PR rust-lang/rustlings#163 accidentally introduced an error using some versions of the Rust compiler where the compiler would (rightly!) complain about an irrefutable let pattern. I have no idea why this did not occur in all versions of the compiler, but here is a way around it.

Adds a simple exercise for structures Thanks for rustlings! Here's a small contribution in return.

…tructs1, r=komaeda Fixes the irrefutable let pattern warning in `structs1.rs` PR rust-lang#163 accidentally introduced an error using some versions of the Rust compiler where the compiler would (rightly!) complain about an irrefutable let pattern. I have no idea why this did not occur in all versions of the compiler, but here is a way around it.

Adds a simple exercise for structures

9b92aa0

komaeda approved these changes May 25, 2019

View reviewed changes

bors added the S-waiting-on-bors label May 25, 2019

bors added a commit that referenced this pull request May 25, 2019

Auto merge of #163 - briankung:add_structs, r=komaeda

1f07fd4

Adds a simple exercise for structures Thanks for rustlings! Here's a small contribution in return.

bors added the merged-by-bors label May 25, 2019

bors merged commit 9b92aa0 into rust-lang:master May 25, 2019

briankung deleted the add_structs branch May 25, 2019 14:00

briankung mentioned this pull request Jun 20, 2019

Fixes the irrefutable let pattern warning in structs1.rs #179

Merged

pedantic79 pushed a commit to pedantic79/rustlings that referenced this pull request Apr 11, 2020

Auto merge of rust-lang#163 - briankung:add_structs, r=komaeda

cdeb31b

Adds a simple exercise for structures Thanks for rustlings! Here's a small contribution in return.

ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022

Auto merge of rust-lang#163 - briankung:add_structs, r=komaeda

7e63b71

Adds a simple exercise for structures Thanks for rustlings! Here's a small contribution in return.

dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022

Auto merge of rust-lang#163 - briankung:add_structs, r=komaeda

d3062a2

Adds a simple exercise for structures Thanks for rustlings! Here's a small contribution in return.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds a simple exercise for structures #163

Adds a simple exercise for structures #163

briankung commented May 25, 2019 •

edited

Loading

komaeda left a comment

komaeda commented May 25, 2019

bors commented May 25, 2019

bors commented May 25, 2019

bors commented May 25, 2019

edmundmiller commented Jun 10, 2019

briankung commented Jun 11, 2019

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019 via email

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019 via email

edmundmiller commented Jun 12, 2019

ksceriath commented Jun 20, 2019

ksceriath commented Jun 20, 2019

briankung commented Jun 20, 2019 •

edited

Loading

briankung commented Jun 20, 2019

ksceriath commented Jun 20, 2019

edmundmiller commented Jun 20, 2019

extrawurst commented Jul 6, 2019

Adds a simple exercise for structures #163

Adds a simple exercise for structures #163

Conversation

briankung commented May 25, 2019 • edited Loading

komaeda left a comment

Choose a reason for hiding this comment

komaeda commented May 25, 2019

bors commented May 25, 2019

bors commented May 25, 2019

bors commented May 25, 2019

edmundmiller commented Jun 10, 2019

briankung commented Jun 11, 2019

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019 via email

edmundmiller commented Jun 11, 2019

briankung commented Jun 11, 2019 via email

edmundmiller commented Jun 12, 2019

ksceriath commented Jun 20, 2019

ksceriath commented Jun 20, 2019

briankung commented Jun 20, 2019 • edited Loading

briankung commented Jun 20, 2019

ksceriath commented Jun 20, 2019

edmundmiller commented Jun 20, 2019

extrawurst commented Jul 6, 2019

briankung commented May 25, 2019 •

edited

Loading

briankung commented Jun 20, 2019 •

edited

Loading