Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two trait-related exercises #216

Closed
wants to merge 2 commits into from
Closed

Add two trait-related exercises #216

wants to merge 2 commits into from

Conversation

s-marios
Copy link

@s-marios s-marios commented Sep 4, 2019

Currently rustlings is lacking any exercises dealing with traits. To address this, I'm submitting two exercises related to implementing a simple trait.

marios added 2 commits September 4, 2019 14:22
Rustlings is currently lacking any exercise that teaches
the basic use syntax and implementation of traits. Adding these
two exercises addresses this issue.
@bors
Copy link
Contributor

bors commented Nov 11, 2019

☔ The latest upstream changes (presumably fbe91a6) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: Waiting on issue/PR author label Nov 11, 2019
@s-marios
Copy link
Author

s-marios commented Dec 6, 2019

Any interest in this?

@shadows-withal
Copy link
Member

Hi @s-marios! Sorry for the delay, I unfortunately can't dedicate as much time as I'd want towards maintaining this project. That being said, I'd love to have your exercises in Rustlings. Judging by the merge conflict we have for this pull request, we've since changed the way hints are handled (they are now sourced from info.toml instead of the file itself). If you update the exercises to match this, I'd be happy to merge it. More info for this can be found in our contributing document. Thanks!

@sjmann
Copy link
Contributor

sjmann commented Feb 22, 2020

@fmoko @s-marios can I pick this up and try to resolve the conflicts for you? I would like to do the traits exercises so I will do it locally anyway

bors added a commit that referenced this pull request Feb 25, 2020
chore: fixed merge conflicts from traits exercises added by s-marios

I hope this doesn't step on any toes but I wanted to try the traits exercises from #216 so I updated them to match the new structure with hints included in info.toml
@shadows-withal
Copy link
Member

Closed by #274!

@s-marios
Copy link
Author

s-marios commented Mar 9, 2020

@fmoko @s-marios can I pick this up and try to resolve the conflicts for you? I would like to do the traits exercises so I will do it locally anyway

Thanks for going through the trouble! Cheers!

pedantic79 pushed a commit to pedantic79/rustlings that referenced this pull request Apr 11, 2020
chore: fixed merge conflicts from traits exercises added by s-marios

I hope this doesn't step on any toes but I wanted to try the traits exercises from rust-lang#216 so I updated them to match the new structure with hints included in info.toml
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
chore: fixed merge conflicts from traits exercises added by s-marios

I hope this doesn't step on any toes but I wanted to try the traits exercises from rust-lang#216 so I updated them to match the new structure with hints included in info.toml
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
chore: fixed merge conflicts from traits exercises added by s-marios

I hope this doesn't step on any toes but I wanted to try the traits exercises from rust-lang#216 so I updated them to match the new structure with hints included in info.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: Waiting on issue/PR author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants