feat: Show a completion message when watching

[codehearts]

The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes #251

Let me know if there are any tests I could add or if the completion message should be tweaked!

[AbdouSeck]

Hi @codehearts,

Thanks for the PR. I noticed that the src/verifiy.rs module was changed to add println! lines in the verify function, and also std::process::exit(0) is used inside the watch function in main.rs. While that's great, both the printing and process exiting could have been done inside the main function. Since both the verify and watch functions have clear return types and values, I thought the following would be easier:

• Have no printing in the module verify since it can be used for something that may not require any printing
• Have watch return Ok(()) whenever verify_result.is_ok() instead of std::process::exit(0) (since the function can be used for something else that may not require process exiting)

Doing the above makes it so that you can do the following inside the main function:

if matches.subcommand_matches("watch").is_some() {
        if let Ok(()) = watch(&exercises) {
            println!("Done with all exercises.");
            // More printing
            std::process::exit(0);
        }
    }

Please keep in mind that these are just suggestions. You're welcome to keep the PR intact. I just thought it might help to move process exiting steps into the main function, so that it is clear that main is the driver of the binary.

Thank you,

Abdou

[codehearts]

I agree with your suggestions, I’ll rebase with that implementation as soon as I can

[codehearts]

I've rebased your suggestions into the original commit, since I think your approach was better. Let me know if there's anything else you see that might need some tweaking!

[AbdouSeck]

Hi @codehearts looks great to me! Thank you!

[shadows-withal]

looks good to me too!

[shadows-withal]

thank you so much!

@bors: r+

[bors]

📌 Commit d25ee55 has been approved by fmoko

[bors]

⌛ Testing commit d25ee55 with merge 0d1f1a1...

[bors]

☀️ Test successful - checks-travis
Approved by: fmoko
Pushing 0d1f1a1 to master...