refactor: exercise evaluation #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrvidal
commented
Feb 20, 2020
| pub stderr: String, | ||
| } | ||
|
|
||
| impl Drop for FileHandle { |
There was a problem hiding this comment.
This is a silly trick to avoid calling clean() all over the place. I think it's not racier than what we were doing before.
jrvidal
commented
Feb 20, 2020
Exercise evaluation (compilation + execution) now uses Results Success/failure messages are standardized
shadows-withal
approved these changes
Feb 25, 2020
| pub stderr: String, | ||
| } | ||
|
|
||
| impl Drop for FileHandle { |
|
Awesome. I do have the |
|
@bors: r+ |
|
📌 Commit 43dc311 has been approved by |
|
☀️ Test successful - checks-travis |
pedantic79
pushed a commit
to pedantic79/rustlings
that referenced
this pull request
Apr 11, 2020
refactor: exercise evaluation After working a bit on rust-lang#270, I realized that it'd be useful to first perform a minor refactor of exercise evaluation. * Now we have standard methods to compile + execute that return `Result`s. * Success/failure messages are standardized.
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
refactor: exercise evaluation After working a bit on rust-lang#270, I realized that it'd be useful to first perform a minor refactor of exercise evaluation. * Now we have standard methods to compile + execute that return `Result`s. * Success/failure messages are standardized.
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
refactor: exercise evaluation After working a bit on rust-lang#270, I realized that it'd be useful to first perform a minor refactor of exercise evaluation. * Now we have standard methods to compile + execute that return `Result`s. * Success/failure messages are standardized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working a bit on #270, I realized that it'd be useful to first perform a minor refactor of exercise evaluation.
Results.