Show tests prints #422
Show tests prints #422
Conversation
This new feature can be accessed by invoking rustlings with --nocapture. Both unit and integration tests added. closes rust-lang#262 BREAKING CHANGES: The following function take a new boolean argument: * `run` * `verify` * `test` * `compile_and_test`
|
ack, I'll look into this ASAP |
| Ok(_) => { | ||
| Ok(output) => { | ||
| if verbose { | ||
| println!("{}", output.stdout); |
There was a problem hiding this comment.
I'm starting to think that we should be a bit more sophisticated while handling the output of exercises, and try to have both stdout and stderr merged as they would appear in the terminal screen.
Anyway, out of scope, just thinking out loud.
There was a problem hiding this comment.
@jrvidal thanks for the review! I agree with providing more information to the end users as long as there is a way to control that; like with command line options to make output --quiet or --verbose.
Normally, an exercise's standard error should be empty unless there is a complication error or a runtime one. Unless someone explicitly uses eprint! or eprintln! (or the many other ways of writing to targeted file handles) in their code to solve an exercise, there should be nothing in the standard error. So, keeping standard output and error separate may actually come in handy when trying to figure out if a user actually wrote to the standard error.
I am open to discussing this further, though.
Thanks!
Abdou
There was a problem hiding this comment.
I'm starting to think that we should be a bit more sophisticated while handling the output of exercises, and try to have both stdout and stderr merged as they would appear in the terminal screen.
Anyway, out of scope, just thinking out loud.
Done in the v6 branch with os_pipe :D
closes rust-lang#423 If the parsed JSON data curled during a bash installation is not valid, use the repository's tag files as a backup. If those files don't exist somehow, then checkout the master branch and install it.
|
I decided to a commit which hopefully closes #423. I just added a couple of steps to check for string emptiness and use Thanks, Abdou |
|
@fmoko please let me know if this needs additional work to get it merged. Thanks, Abdou |
|
@AbdouSeck All good! Just went under my radar. |
This new feature can be accessed by invoking rustlings with
--nocapture.closes #262
MINOR CHANGES:
* Documentation added to source code under
src* Both unit and integration tests for
--nocapturehave been added.BREAKING CHANGES:
The following function take a new boolean argument:
*
run*
verify*
test*
compile_and_testcompile_and_testis the function that uses this new boolean argument to determine whether or not to display the output from the test harnesses.Please feel free to reach out with any questions.
Thank you,
Abdou