Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change &mut *y to &mut x #814

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Change &mut *y to &mut x #814

merged 1 commit into from
Sep 25, 2021

Conversation

frogtd
Copy link
Contributor

@frogtd frogtd commented Aug 5, 2021 •
edited
Loading

Instead of having to explain why

let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;

and

let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;

are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040
(this is in the rust community discord https://discord.com/invite/rust-lang-community)

@frogtd
Change &mut *y to &mut x
ffab0c4 
Instead of having to explain why 
```rs
let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and 
```rs
let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040>
shadows-withal
shadows-withal approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@shadows-withal shadows-withal merged commit d75759e into rust-lang:main Sep 25, 2021
@shadows-withal
Copy link
Member

@all-contributors please add @frogtd for content

@allcontributors allcontributors bot mentioned this pull request Sep 25, 2021
Merged
@allcontributors
Copy link
Contributor

@diannasoriel

I've put up a pull request to add @frogtd! 🎉

catull pushed a commit to catull/rustlings that referenced this pull request Oct 21, 2021
@frogtd @catull
fix(move_semantics5): change &mut *y to &mut x (rust-lang#814)
c63edac 
Instead of having to explain why 
```rs
let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and 
```rs
let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040>
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this pull request Dec 28, 2021
@frogtd
fix(move_semantics5): change &mut *y to &mut x (rust-lang#814)
3a7e4c2 
Instead of having to explain why 
```rs
let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and 
```rs
let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040>
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
fix(move_semantics5): change &mut *y to &mut x (rust-lang#814)
afa5ca5 
Instead of having to explain why 
```rs
let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and 
```rs
let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040>
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
@frogtd
fix(move_semantics5): change &mut *y to &mut x (rust-lang#814)
cfbc72e 
Instead of having to explain why 
```rs
let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and 
```rs
let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040>
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this pull request Nov 18, 2022
@frogtd @Spacebody
fix(move_semantics5): change &mut *y to &mut x (rust-lang#814)
fc79f34 
Instead of having to explain why 
```rs
let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and 
```rs
let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040>
ComixHe pushed a commit to ComixHe/rustlings that referenced this pull request Jun 20, 2023
@frogtd @ComixHe
fix(move_semantics5): change &mut *y to &mut x (rust-lang#814)
cd8d68a 
Instead of having to explain why 
```rs
let mut x = 100; 
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and 
```rs
let mut x = 100; 
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.

Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadows-withal shadows-withal shadows-withal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frogtd @shadows-withal