Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow omitting patch version in toolchain specifiers #794

Closed
kamalmarhubi opened this issue Nov 4, 2016 · 0 comments · Fixed by #2551
Closed

Allow omitting patch version in toolchain specifiers #794

kamalmarhubi opened this issue Nov 4, 2016 · 0 comments · Fixed by #2551
Assignees

Comments

@kamalmarhubi
Copy link
Contributor

Example use cases:

Installation / update

$ rustup install 1.8
error: toolchain '1.8' is not installed

(I've filed #793 for the confusing error message.)

I think this should install the highest version matching semver requirement ~1.8. For the recent case of 1.12.1, installing 1.12 should therefore install 1.12.1. 1.12.1 should be installed even if the user has 1.12.0 installed.

Run

$ rustup run 1.8 rustc test.rs
error: toolchain '1.8' is not installed

This should be equivalent to specifying the highest installed version matching ~1.8. In this case, I expect it to be equivalent to rustup run 1.8.0 cargo test.

For 1.12, if the user has 1.12.0 installed, then

$ rustup run 1.12 rustc test.rs

should run with 1.12.0, but if they have 1.12.1 installed, it should run with 1.12.1.

Together with #792, this leads to really confusing behavior: rustup run 1.8 cargo test will silently use nightly, since even if you have 1.8.0 installed, that's not 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants