correctly uninstall toolchains that are stale symlinks #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found a way to test this. Now I guess I will see whether this also works on Windows... |
|
☔ The latest upstream changes (presumably #1229) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm happy to rebase, but I'd appreciate to get some form of feedback on whether this approach is even going to get accepted. |
|
The fix looks good to me, sorry for the delay here! I'll r+ if you'd like to rebase |
|
Great :) |
|
@bors: r+ |
|
📌 Commit 984c997 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 12, 2017
correctly uninstall toolchains that are stale symlinks Fixes #1169 I'd like to add a test for this -- what is the best way to do that?
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1169
I'd like to add a test for this -- what is the best way to do that?