do not get cwd if not env set #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
commented
Mar 17, 2018
tests/cli-rustup.rs
Outdated
| let non_existing_dir = config.homedir.join(".remove_me"); | ||
| let mut cmd = clitools::cmd(config, "rustup", &["-h"]); | ||
| cmd.env_remove("CARGO_HOME"); | ||
| cmd.current_dir(non_existing_dir); |
There was a problem hiding this comment.
I'm trying to write a basic test here, but seems like cmd is checking the directory prior to executing the command and so failing with a no such file or directory. Any ideas on how to test this out?
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
rustup-from-non-existing-path
branch
from
3df4596
to
3c7726c
Compare
|
☔ The latest upstream changes (presumably #1390) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #1395) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #897
/cc @lu-zero
Signed-off-by: Antonio Murdaca runcom@redhat.com