Allow using inherited RUSTUP_UPDATE_ROOT variable in rustup-init.sh. #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes the usage of the variable consistent with rust version by moving the "/dist" part to usage site.
|
Will this merge? this is really useful for those who can not access to official website |
|
This change seems harmless and, given the comments about China, useful. I think it'd be okay to merge. |
nrc
approved these changes
Jan 7, 2019
AJ-Ianozi
pushed a commit
to AJ-Ianozi/getada-download
that referenced
this pull request
Oct 12, 2023
Allow using inherited RUSTUP_UPDATE_ROOT variable in rustup-init.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes the usage of the variable consistent with rust version by moving the "/dist" part to usage site.
For people in mainland China, Amazon web hosting and cdn services are inaccessible. Using this patch, we can set the
RUSTUP_UPDATE_ROOTvariable beforehand to askrustup-init.shto download rustup-init.exe from a mirror site.