rustup-init: remove dependency on file command
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some distros don't install file(1) by default. For the purposes of userspace architecture detection, rather than screenscrape file(1), we can check the ELF header directly with only tools that are included in the default coreutils. Note that printf is a builtin in some shells (like /bin/dash on Debian), and may be less featureful than the one from coreutils, but that the syntax here should work on all such shells. Tested against bash, dash, and busybox sh.
|
r? @brson Seems like a neat trick to me! |
|
@zarvox you ninja! |
AJ-Ianozi
pushed a commit
to AJ-Ianozi/getada-download
that referenced
this pull request
Oct 12, 2023
rustup-init: remove dependency on `file` command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some distros don't install file(1) by default. For the purposes of userspace
architecture detection, rather than screenscrape file(1), we can check the ELF
header directly with only tools that are included in the default coreutils.
Note that printf is a builtin in some shells (like /bin/dash on Debian), and
may be less featureful than the one from coreutils, but that the syntax here
should work on all such shells.
Tested against bash, dash, and busybox sh.