Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crates-io): destroy old downloads archive #467

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

MarcoIeni
Copy link
Member

@MarcoIeni MarcoIeni commented Aug 1, 2024

Related to #436

Plan:

  • get this merged
  • run terragrunt apply in:
    • simpleinfra/terragrunt/accounts/crates-io-staging
    • simpleinfra/terragrunt/accounts/crates-io-prod
  • raise another PR where I delete the following directories:
    • simpleinfra/terragrunt/accounts/crates-io-staging
    • simpleinfra/terragrunt/accounts/crates-io-prod
    • terragrunt/modules/crates-io-downloads-archive/

Is this everything required to completely delete these two terragrunt states?

@MarcoIeni MarcoIeni marked this pull request as ready for review August 1, 2024 15:18
@jdno
Copy link
Member

jdno commented Aug 5, 2024

Let's keep the accounts (e.g. simpleinfra/terragrunt/accounts/crates-io-prod) and only delete the states (e.g. simpleinfra/terragrunt/accounts/crates-io-prod/crates-io-downloads-archive).

@MarcoIeni
Copy link
Member Author

MarcoIeni commented Aug 5, 2024

oh, right! The accounts have more than this bucket, so it makes sense to only delete only the state! So new plan:

  • get this merged
  • run terragrunt apply in:
    • simpleinfra/terragrunt/accounts/crates-io-staging/crates-io-downloads-archive/
    • simpleinfra/terragrunt/accounts/crates-io-prod/crates-io-downloads-archive/
  • raise another PR where I delete the following directories:
    • simpleinfra/terragrunt/accounts/crates-io-staging/crates-io-downloads-archive
    • simpleinfra/terragrunt/accounts/crates-io-prod/crates-io-downloads-archive
    • terragrunt/modules/crates-io-downloads-archive/

@MarcoIeni MarcoIeni force-pushed the chore-crates-io-destroy-old-downloads-archive branch from e48dc71 to b5bbdf1 Compare August 5, 2024 08:07
@MarcoIeni MarcoIeni merged commit 73d6d54 into master Aug 5, 2024
6 checks passed
@MarcoIeni MarcoIeni deleted the chore-crates-io-destroy-old-downloads-archive branch August 5, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants