Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Stabilizing features" has broken links and unclear instructions #47

Closed
Xiretza opened this issue Jan 7, 2023 · 1 comment · Fixed by #48 · May be fixed by #49
Closed

"Stabilizing features" has broken links and unclear instructions #47

Xiretza opened this issue Jan 7, 2023 · 1 comment · Fixed by #48 · May be fixed by #49

Comments

@Xiretza
Copy link

Xiretza commented Jan 7, 2023

https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html has two links labeled "libs team reviewers" that lead to https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json, which doesn't exist. It also says to "either ping @rust-lang/libs-api or leave a comment asking about the status of the feature", but it's not clear what "ping" means here; it seems to be distinct from "leav[ing] a comment", and even if it does mean leaving a comment with that tag in it, that doesn't appear to work (at least it doesn't get highlighted in the rendered comment like a user would be).

@JohnTitor
Copy link
Member

std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html has two links labeled "libs team reviewers" that lead to rust-lang/highfive@master/highfive/configs/rust-lang/rust.json, which doesn't exist.

Because we migrated to triagebot, it now lives on https://github.com/rust-lang/rust/blob/e5d46a5bdac3f19793297914d4ada432024fbe95/triagebot.toml#L459. It's just a left-over on the migration.

It also says to "either ping @rust-lang/libs-api or leave a comment asking about the status of the feature", but it's not clear what "ping" means here; it seems to be distinct from "leav[ing] a comment",

"ping" here means mentioning the team via a comment. Here's a formal definition: https://dictionary.cambridge.org/dictionary/english/ping

and even if it does mean leaving a comment with that tag in it, that doesn't appear to work (at least it doesn't get highlighted in the rendered comment like a user would be).

GitHub doesn't allow you to mention the team if you aren't a part of the organization. In such a case, you can leave a comment instead (that's why we wrote "either...").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants