wasm: Mark most simd intrinsics as safe #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
This updates all simd intrinsics to be safe to account for rust-lang/rust#84988. In the spirit of more safety it also removes the pervasive usage of `transmute` in the intrinsics in favor of more targeted casts.
|
Ok safe support has landed in nightly and at least that test is green. The documentation is failing to build, though, since rustdoc is still requiring target_feature functions to be I plan on having a follow-up after this lands which actually applies stabilization to all intrinsics. |
|
Ok with the latest nightly this is all green and should be good to land now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all simd intrinsics to be safe to account for
rust-lang/rust#84988. In the spirit of more safety it also removes the
pervasive usage of
transmutein the intrinsics in favor of moretargeted casts.