Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete trailing whitespace from wg-embedded subteam descriptions #1189

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 9, 2024

This whitespace is problematic because it ends up as line-ending whitespace in the www.rust-lang.org repo in locales/en-US/teams.ftl after running dump-website.

https://github.com/rust-lang/www.rust-lang.org/blob/c4222cef26489f0a3925349d20725dcb70a919f7/locales/en-US/teams.ftl#L188-L195

and various editors will object to that. One person will run cargo run -- dump-website > ../www.rust-lang.org/locales/en-US/teams.ftl and commit it, the next person will make some unrelated change and end up with spurious diffs on the lines with whitespace.

@jackh726 jackh726 merged commit 1eb802c into rust-lang:master Jan 10, 2024
1 check passed
@dtolnay dtolnay deleted the whitespace branch January 10, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants