create the "compiler contributors team" and populate it

[nikomatsakis]

Contributors are added to the compiler-team mailing list, as well.

One question mark: I would like to tweak how the github teams are setup, but I'm not sure if that is controlled by this repository. I think I would prefer to have @rust-lang/compiler include the contributors, and to have some subteam to distinguish "full members" (I believe that is what I specified in the RFC).

cc @rust-lang/compiler
r? @pietroalbini

[pietroalbini]

You'll also need to remove the explicit permissions from the people you added in a team (this is done to avoid keeping permissions unintentionally after removing people from teams).

[pietroalbini]

A description is missing.

[pietroalbini]

Oh, yeah, I also didn't get a chance to setup github teams sync, and I'll probably won't have time in a while (there is the CI stuff to do).

[davidtwco]

Does it make sense for this to be a subteam of the compiler team?

Suggested change

	name = "compiler-contributors"
	name = "compiler-contributors"
	subteam-of = "compiler"

[nikomatsakis]

I don't really know what "subteam" means, actually

[nikomatsakis]

In the GH sense, it is not a subteam.

[davidtwco]

I think that on the website, if the compiler contributors were not a subteam, then the two teams would be listed as siblings on the teams page. But if added as a subteam, then the compiler contributors would be shown on the same page as the compiler team.

For example, the Cargo team is a sub-team of the Dev Tools team and appears on the Dev Tools team page.

[davidtwco]

I don't know how this would affect the GitHub team structure.

[Manishearth]

This doesn't affect the github teams at all.

[pietroalbini]

Yeah, subteam is only used as part of the website.

[nikomatsakis]

OK, I added a description of "folks who contribute on a regular basis" -- maybe not the best but I wasn't sure what to put there.

I removed the redundant permissions.

I also added it as a subteam of compiler.

[pietroalbini]

You also need to add lqd and flodiebold's files in the people/ directory.

You can check everything is ok locally with: cargo run check

[nikomatsakis]

OK, I added the people files.

cargo run check, however, fails because the following folks don't have e-mail addresses:

• @flodiebold
• @nikic
• @nnethercote
• @scalexm
• @tmandry
• @zackmdavis

Can y'all send me the e-mail address where you'd like to get rust-lang related mail (i.e., messages sent to compiler-team@rust-lang.org)? (Over Zulip, or as comments here, whatever.) This e-mail address would be stored in this repo and hence publicly "scrape-able", I suppose.

(If you'd rather not get such mail, then you might want to bother @pietroalbini to make the email field optional.)

[pietroalbini]

(If you'd rather not get such mail, then you might want to bother @pietroalbini to make the email field optional.)

You can explicitly set email = false.

[nikomatsakis]

OK, I've set e-mail=false for most of the folks cc'd above. They can open their own PRs later if they like. =)

[zackmdavis]

Suggested change

	email = false
	email = "code@zackmdavis.net"

[pietroalbini]

Looks good, you can merge once you're ok with it!