-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create the "compiler contributors team" and populate it #66
Merged
nikomatsakis
merged 15 commits into
rust-lang:master
from
nikomatsakis:compiler-contributors
May 29, 2019
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f0a085c
create the "compiler contributors team" and populate it
nikomatsakis dce3f2a
sort names
nikomatsakis 4f187a8
add Nikita Popov
nikomatsakis 1b233cc
add as a subteam of compiler
nikomatsakis e0cc06f
remove explicit permissions that are redundant
nikomatsakis 88deea0
give a description
nikomatsakis 406b4dd
Update teams/compiler-contributors.toml
nikomatsakis fce58c5
add people/flodiebold and people/lqd
nikomatsakis 62faa2e
add flodiebold email
nikomatsakis 8630f66
set e-mail=false for remaining contributors
nikomatsakis dc5e1a5
Update people/nikic.toml
nikomatsakis 786d38c
Update people/scalexm.toml
nikomatsakis 9cc48f3
Update people/nnethercote.toml
nikomatsakis 8060af2
Update people/tmandry.toml
nikomatsakis d25e5e3
add davidtwco
nikomatsakis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
name = "Matthew Jasper" | ||
github = "matthewjasper" | ||
email = "mjjasper1@gmail.com" | ||
|
||
[permissions] | ||
crater = true | ||
bors.rust.review = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,2 @@ | ||
name = "Nikita Popov" | ||
github = "nikic" | ||
|
||
[permissions] | ||
bors.rust.review = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,2 @@ | ||
name = "Nicholas Nethercote" | ||
github = "nnethercote" | ||
|
||
[permissions] | ||
perf = true | ||
bors.rust.review = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,2 @@ | ||
name = "Alexandre Martin" | ||
github = "scalexm" | ||
|
||
[permissions] | ||
bors.rust.review = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,2 @@ | ||
name = "Tyler Mandry" | ||
github = "tmandry" | ||
|
||
[permissions] | ||
bors.rust.review = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
name = "Wesley Wiser" | ||
github = "wesleywiser" | ||
email = "wwiser@gmail.com" | ||
|
||
[permissions] | ||
bors.rust.review = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,2 @@ | ||
name = "Zack M. Davis" | ||
github = "zackmdavis" | ||
|
||
[permissions] | ||
bors.rust.review = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name = "compiler-contributors" | ||
subteam-of = "compiler" | ||
|
||
[people] | ||
leads = [] | ||
members = [ | ||
"flodiebold", | ||
"lqd", | ||
"matklad", | ||
"matthewjasper", | ||
"nikic", | ||
"nnethercote", | ||
"scalexm", | ||
"spastorino", | ||
"tmandry", | ||
"wesleywiser", | ||
"xanewok", | ||
nikomatsakis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"zackmdavis", | ||
] | ||
|
||
[permissions] | ||
perf = true | ||
nikomatsakis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
crater = true | ||
bors.rust.review = true | ||
|
||
[website] | ||
name = "Compiler team contributors" | ||
repo = "http://github.com/rust-lang/compiler-team" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A description is missing. |
||
description = "folks who contribute on a regular basis" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense for this to be a subteam of the compiler team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know what "subteam" means, actually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the GH sense, it is not a subteam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that on the website, if the compiler contributors were not a subteam, then the two teams would be listed as siblings on the teams page. But if added as a subteam, then the compiler contributors would be shown on the same page as the compiler team.
For example, the Cargo team is a sub-team of the Dev Tools team and appears on the Dev Tools team page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how this would affect the GitHub team structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't affect the github teams at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, subteam is only used as part of the website.