Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create the "compiler contributors team" and populate it #66

Merged
merged 15 commits into from
May 29, 2019
Merged
2 changes: 0 additions & 2 deletions people/Xanewok.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,4 @@ github = "Xanewok"
email = "xanewok@gmail.com"

[permissions]
perf = true
bors.rust.review = true
bors.rls.review = true
4 changes: 0 additions & 4 deletions people/matthewjasper.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
name = "Matthew Jasper"
github = "matthewjasper"
email = "mjjasper1@gmail.com"

[permissions]
crater = true
bors.rust.review = true
3 changes: 0 additions & 3 deletions people/nikic.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
name = "Nikita Popov"
github = "nikic"

[permissions]
bors.rust.review = true
4 changes: 0 additions & 4 deletions people/nnethercote.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
name = "Nicholas Nethercote"
github = "nnethercote"

[permissions]
perf = true
bors.rust.review = true
3 changes: 0 additions & 3 deletions people/scalexm.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
name = "Alexandre Martin"
github = "scalexm"

[permissions]
bors.rust.review = true
3 changes: 0 additions & 3 deletions people/tmandry.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
name = "Tyler Mandry"
github = "tmandry"

[permissions]
bors.rust.review = true
3 changes: 0 additions & 3 deletions people/wesleywiser.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
name = "Wesley Wiser"
github = "wesleywiser"
email = "wwiser@gmail.com"

[permissions]
bors.rust.review = true
3 changes: 0 additions & 3 deletions people/zackmdavis.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
name = "Zack M. Davis"
github = "zackmdavis"

[permissions]
bors.rust.review = true
29 changes: 29 additions & 0 deletions teams/compiler-contributors.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name = "compiler-contributors"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for this to be a subteam of the compiler team?

Suggested change
name = "compiler-contributors"
name = "compiler-contributors"
subteam-of = "compiler"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what "subteam" means, actually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the GH sense, it is not a subteam.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that on the website, if the compiler contributors were not a subteam, then the two teams would be listed as siblings on the teams page. But if added as a subteam, then the compiler contributors would be shown on the same page as the compiler team.

For example, the Cargo team is a sub-team of the Dev Tools team and appears on the Dev Tools team page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this would affect the GitHub team structure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect the github teams at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, subteam is only used as part of the website.

subteam-of = "compiler"

[people]
leads = []
members = [
"flodiebold",
"lqd",
"matklad",
"matthewjasper",
"nikic",
"nnethercote",
"scalexm",
"spastorino",
"tmandry",
"wesleywiser",
"xanewok",
nikomatsakis marked this conversation as resolved.
Show resolved Hide resolved
"zackmdavis",
]

[permissions]
perf = true
nikomatsakis marked this conversation as resolved.
Show resolved Hide resolved
crater = true
bors.rust.review = true

[website]
name = "Compiler team contributors"
repo = "http://github.com/rust-lang/compiler-team"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A description is missing.

description = "folks who contribute on a regular basis"
2 changes: 2 additions & 0 deletions teams/compiler.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,15 @@ address = "compiler-private@rust-lang.org"

[[lists]]
address = "compiler@rust-lang.org"
extra-teams = ["compiler-contributors"]
extra-people = [
"arielb1",
"jseyfried",
]

[[lists]]
address = "compiler-team@rust-lang.org"
extra-teams = ["compiler-contributors"]
extra-people = [
"arielb1",
"jseyfried",
Expand Down