Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWIR 121's CotW + PRs #176

Closed
llogiq opened this issue Mar 6, 2016 · 13 comments
Closed

TWIR 121's CotW + PRs #176

llogiq opened this issue Mar 6, 2016 · 13 comments

Comments

@llogiq
Copy link
Contributor

llogiq commented Mar 6, 2016

This week's Crate of the Week is preferences which does the right thing to your program's preferences on all common operating systems.

Interesting PRs:

rust-lang/rust#32055 no more private imports in rustdoc
rust-lang/rust#32039 rustc will catch missing fields in pattern matches again
rust-lang/rust#32032 regression fix for LLVM type errors with bools
rust-lang/rust#32012 Vecs and VecDeques now drop faster ;-)
rust-lang/rust#32007 compiletest gets some more capabilities
rust-lang/rust#31999 slice.as_ptr generates simpler LLVM IR
rust-lang/rust#31996 libc update
rust-lang/rust#31989 Patterns can now be pointers-to-pointers to str with different lifetimes
rust-lang/rust#31985 libstd can now be compiled with emscripten
rust-lang/rust#31962 One less internal compiler error with trait consts
rust-lang/rust#31945 implement RFC 1461
rust-lang/rust#31928 Stabilized APIs for 1.8
rust-lang/rust#31937 Positional fields are now named starting from "0", "1", ..
rust-lang/rust#31797 vec![..] no longer copies from the stack
rust-lang/rust#31430 zeroing on drop
rust-lang/rust#31335 AsciiExt::in_ascii_{lower, upper}case
rust-lang/rust#30884 Implement inclusive ranges

@abonander
Copy link
Contributor

How did preferences make CotW if it was never nominated? Is selection arbitrary now?

@nasa42
Copy link
Member

nasa42 commented Mar 7, 2016

We still accept nominations. I'm assuming because of lack of nominations, @llogiq himself nominated this week's CotW.

@abonander
Copy link
Contributor

There was a single nomination but it didn't get any votes. There was no bumping/call-to-arms comment like previous voting cycles, actually hasn't been for a month or so.

@nasa42
Copy link
Member

nasa42 commented Mar 7, 2016

I ask for nomination for next week's CotW is every single issue of TWiR. :-)

@abonander
Copy link
Contributor

Ah, ok. Can you make sure my announcement for multipart makes this week's issue? Thanks. 👍

@nasa42
Copy link
Member

nasa42 commented Mar 7, 2016

@cybergeek94 multipart has already been mentioned in an old TWiR issue! :-)
if you are looking for contributors and also mentoring as your post mentions, I'd suggest you to take a look at Call for Participation thread. Please create a separate issue per task as well as add a east/medium/hard label and I'll included them in the next TWiR issue!

@nasa42
Copy link
Member

nasa42 commented Mar 7, 2016

Thanks @llogiq, those PR annotations are awesome!

@nasa42 nasa42 closed this as completed Mar 7, 2016
@llogiq
Copy link
Contributor Author

llogiq commented Mar 7, 2016

My pleasure.

@cybergeek94 I was on mobile for some time, so I didn't get around to nag you folks, and since there was only one self-reported crate without votes, I took it upon myself to choose. I'll see if I find the time tomorrow to write a nag message to rust-users and /r/rust.

@abonander
Copy link
Contributor

@nasa42 So only one mention, ever, with no statute of limitations? That was back in December 2014 with the first release. What about "Project Updates"?

@bluss
Copy link
Member

bluss commented Mar 7, 2016

I think using editorial discretion for crates, when needed, is great @llogiq

@llogiq
Copy link
Contributor Author

llogiq commented Mar 7, 2016

I think I should go back to nagging. It also gives me more of those internet points to buy cat pictures with or something...

@abonander
Copy link
Contributor

@nasa42 I couldn't help but notice that Leaf got an update mention this issue even though it was released back in November, and got a mention then. Several others have been mentioned multiple times as well. If you didn't want to edit this week's issue this late that's all you had to say, I would have been fine waiting for the next one.

I've had couple other projects, new and updated, get omitted from TWiR in recent memory, so it's really hard not to take this personally.

@nasa42
Copy link
Member

nasa42 commented Mar 8, 2016

@cybergeek94 First of all, I'm sorry that my actions (or lack thereof) made you feel that way.

If you think that I missed mentioning some of your projects, it would be mostly because I missed your project announcements or it didn't meet notability requirements*. It is far more likely that I missed your project announcements on Reddit or on Rust forums. But you can always tweet to us to ensure it gets our attention! (or create a PR).

I usually announce a project only once, and after that only project updates. The Leaf mention is about a project update which happened last week. It's hard to ignore it because of sheer amount of upvotes on its Reddit thread.

When I looked at your announcement, I noticed "mentoring" word in the title and assumed that it would be a better fit for Call for Participation and suggested you to create separate issues per task so that I can include it in that section. Now, that I read your announcement post again and yes it is something that should be mentioned in Project Updates. Can you please make a PR for it to get included to the next issue?

Please also make PRs for your projects which have not yet been included in TWiR. I suggest you to announce one project per week and keep your project announcements distributed across multiple weeks for maximum exposure.

*I do not have specific guidelines of notability yet, but given the (comparatively) small size of Rust community, the requirements are very relaxed. Basically, it should have a proper README, good enough number of stars on GitHub, or good enough votes on announcement post on Reddit, or I've personally found the project interesting, or author has directly asked TWiR for mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@nasa42 @abonander @bluss @llogiq and others