Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage labels in triagebot.toml #1681

Open
weihanglo opened this issue Feb 4, 2023 · 6 comments
Open

Manage labels in triagebot.toml #1681

weihanglo opened this issue Feb 4, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@weihanglo
Copy link
Member

What

Would like to define labels in triagebot.toml and make them in sync with GitHub. Maybe sync them from triagebot.toml but not the other way around.

From: rust-lang/cargo#11679 (comment)

How

Given an autolabel table:

[autolabel."A-dependency-resolution"]
description = "Area: dependency resolution and the resolver"
color = "fbca04"
trigger_files = [
  "benches/benchsuite/benches/resolve.rs",
  "crates/resolver-tests/",
  "src/cargo/core/resolver/",
]

triagebot will try to create or update that label when triagebot.toml gets updates.

@weihanglo
Copy link
Member Author

I could help the work if this feature is accepted. Thank you :)

@apiraino

This comment was marked as off-topic.

@Mark-Simulacrum
Copy link
Member

I don't think creation of labels needs to be part of auto label (you might want a label but not automate tagging PRs with it).

I think the label definitions would live per repository (triagebot.toml already lives in each repository), so this seems quite reasonable - not sure I follow discussion around cargo.

@weihanglo
Copy link
Member Author

Am I reading correctly the proposal?

I am not sure if we are on the same page. Autolabeling is already a thing. What I request here is an extension of autolabels feature: "If triagebot notices there is a [autolabel."<label-name>"], create a label if not exists, or update it."

@Mark-Simulacrum, do you suggest a new table for the defining labels? I am a bit afraid of those definitions becoming duplicated.

@Mark-Simulacrum
Copy link
Member

Yes, a separate table makes sense to me. I'm not very worried about duplication, the two sections can be side by side.

@apiraino
Copy link
Contributor

apiraino commented Feb 5, 2023

sorry I clearly had not enough context to express an opinion. Thanks for clarifying.

@ehuss ehuss added the enhancement New feature or request label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants