chore: autolabel more for `A-*` #11679

weihanglo · 2023-02-04T00:21:44Z

What does this PR try to resolve?

A follow-up of #11664 for most A-* labels. We have a doc here tracking autolabel stuff.

How should we test and review this PR?

All trigger_files fields are based on human knowledge, some labels are hard to determine.
The rule to apply a label on a file: What a file does ⊂ What a label describes.
This is a bit conservative. Shall we be more aggressive? So that it will hurt us and make us know how to improve.

Some files are not included in any of label. Most of them are utilities or types definitions. I think that makes sense not including them at this moment.

rustbot · 2023-02-04T00:21:49Z

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

weihanglo · 2023-02-04T00:21:52Z

cc @Muscraft

triagebot.toml

epage · 2023-02-04T01:01:06Z

I feel like this change does a couple of things

Provides a resource to go from topic -> code
Helps highlight our current organization for improvement
Helps highlight our current tags for improvement

Muscraft

Looks good!

Do you think we should include the label descriptions above the table? It has helped me classify what should go where a few times. I am not sure it is needed in this PR just something to think about.

triagebot.toml

weihanglo · 2023-02-04T08:43:41Z

Do you think we should include the label descriptions above the table? It has helped me classify what should go where a few times. I am not sure it is needed in this PR just something to think about.

Or maybe we could teach triagebot how to manage labels based on triagebot.toml? That would be way better than syncing them by hand 😆.

ehuss · 2023-02-05T23:32:48Z

Thanks!

@bors r+

bors · 2023-02-05T23:32:50Z

📌 Commit dd067b3 has been approved by ehuss

It is now in the queue for this repository.

bors · 2023-02-05T23:32:57Z

⌛ Testing commit dd067b3 with merge f290ec5...

chore: autolabel more for `A-*` ### What does this PR try to resolve? A follow-up of #11664 for most `A-*` labels. We have a [doc here][hackmd] tracking autolabel stuff. ### How should we test and review this PR? All `trigger_files` fields are based on human knowledge, some labels are hard to determine. The rule to apply a label on a file: *What a file does ⊂ What a label describes*. This is a bit conservative. Shall we be more aggressive? So that it will hurt us and make us know how to improve. [hackmd]: https://hackmd.io/cNsQWpKyRSWHlgVAIYUFdg Some files are not included in any of label. Most of them are utilities or types definitions. I think that makes sense not including them at this moment.

bors · 2023-02-05T23:39:38Z

💔 Test failed - checks-actions

ehuss · 2023-02-06T00:08:17Z

CI will be blocked until rust-lang/rust#107688 lands in nightly.

weihanglo · 2023-02-08T07:49:04Z

@bors retry

bors · 2023-02-08T07:49:13Z

⌛ Testing commit dd067b3 with merge 55e5fb3...

chore: autolabel more for `A-*` ### What does this PR try to resolve? A follow-up of #11664 for most `A-*` labels. We have a [doc here][hackmd] tracking autolabel stuff. ### How should we test and review this PR? All `trigger_files` fields are based on human knowledge, some labels are hard to determine. The rule to apply a label on a file: *What a file does ⊂ What a label describes*. This is a bit conservative. Shall we be more aggressive? So that it will hurt us and make us know how to improve. [hackmd]: https://hackmd.io/cNsQWpKyRSWHlgVAIYUFdg Some files are not included in any of label. Most of them are utilities or types definitions. I think that makes sense not including them at this moment.

bors · 2023-02-08T07:55:49Z

💔 Test failed - checks-actions

weihanglo · 2023-02-08T08:46:36Z

I was wrong. Not yet landed 😅

ehuss · 2023-02-09T04:13:20Z

@bors r+

bors · 2023-02-09T04:13:22Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

bors · 2023-02-09T04:13:23Z

📌 Commit dd067b3 has been approved by ehuss

It is now in the queue for this repository.

bors · 2023-02-09T04:13:30Z

⌛ Testing commit dd067b3 with merge 2286d5f...

bors · 2023-02-09T04:59:55Z

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 2286d5f to master...

10 commits in 82c3bb79e3a19a5164e33819ef81bfc2c984bc56..39c13e67a5962466cc7253d41bc1099bbcb224c3 2023-02-04 22:52:16 +0000 to 2023-02-12 02:01:08 +0000 - chore: Update to toml v0.6, toml_edit v0.18 (rust-lang/cargo#11618) - doc: more doc comments and intra-doc links (rust-lang/cargo#11703) - Deny warnings in CI, not locally (rust-lang/cargo#11699) - add comment to lto.rs (rust-lang/cargo#11701) - Re-export cargo_new::NewProjectKind as public (rust-lang/cargo#11700) - Add '-C' flag for changing current dir before build (rust-lang/cargo#10952) - `-Zrustdoc-scrape-example` must fail with bad build script (rust-lang/cargo#11694) - Update CHANGELOG for 1.68 backports (rust-lang/cargo#11690) - Update 1password to the version 2 CLI (rust-lang/cargo#11692) - chore: autolabel more for `A-*` (rust-lang/cargo#11679)

Update cargo 10 commits in 82c3bb79e3a19a5164e33819ef81bfc2c984bc56..39c13e67a5962466cc7253d41bc1099bbcb224c3 2023-02-04 22:52:16 +0000 to 2023-02-12 02:01:08 +0000 - chore: Update to toml v0.6, toml_edit v0.18 (rust-lang/cargo#11618) - doc: more doc comments and intra-doc links (rust-lang/cargo#11703) - Deny warnings in CI, not locally (rust-lang/cargo#11699) - add comment to lto.rs (rust-lang/cargo#11701) - Re-export cargo_new::NewProjectKind as public (rust-lang/cargo#11700) - Add '-C' flag for changing current dir before build (rust-lang/cargo#10952) - `-Zrustdoc-scrape-example` must fail with bad build script (rust-lang/cargo#11694) - Update CHANGELOG for 1.68 backports (rust-lang/cargo#11690) - Update 1password to the version 2 CLI (rust-lang/cargo#11692) - chore: autolabel more for `A-*` (rust-lang/cargo#11679) r? `@ghost`

rustbot assigned ehuss Feb 4, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2023

epage reviewed Feb 4, 2023

View reviewed changes

triagebot.toml Outdated Show resolved Hide resolved

triagebot.toml Outdated Show resolved Hide resolved

weihanglo force-pushed the autolabel branch from f28c2fa to 3d8b672 Compare February 4, 2023 01:10

Muscraft reviewed Feb 4, 2023

View reviewed changes

triagebot.toml Show resolved Hide resolved

chore: autolabel more for A-*

dd067b3

weihanglo force-pushed the autolabel branch from 3d8b672 to dd067b3 Compare February 4, 2023 08:33

weihanglo mentioned this pull request Feb 4, 2023

Manage labels in triagebot.toml rust-lang/triagebot#1681

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2023

Muscraft mentioned this pull request Feb 6, 2023

Do not mention a non-existing default of crates.io #11685

Closed

epage mentioned this pull request Feb 7, 2023

feat(resolver): -Zdirect-minimal-versions #11688

Merged

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2023

bors merged commit 2286d5f into rust-lang:master Feb 9, 2023

weihanglo deleted the autolabel branch February 9, 2023 06:46

weihanglo mentioned this pull request Feb 13, 2023

Update cargo rust-lang/rust#107993

Merged

ehuss added this to the 1.69.0 milestone Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: autolabel more for `A-*` #11679

chore: autolabel more for `A-*` #11679

weihanglo commented Feb 4, 2023

rustbot commented Feb 4, 2023

weihanglo commented Feb 4, 2023

epage commented Feb 4, 2023

Muscraft left a comment •

edited

Loading

weihanglo commented Feb 4, 2023

ehuss commented Feb 5, 2023

bors commented Feb 5, 2023

bors commented Feb 5, 2023

bors commented Feb 5, 2023

ehuss commented Feb 6, 2023

weihanglo commented Feb 8, 2023

bors commented Feb 8, 2023

bors commented Feb 8, 2023

weihanglo commented Feb 8, 2023

ehuss commented Feb 9, 2023

bors commented Feb 9, 2023

bors commented Feb 9, 2023

bors commented Feb 9, 2023

bors commented Feb 9, 2023

chore: autolabel more for A-* #11679

chore: autolabel more for A-* #11679

Conversation

weihanglo commented Feb 4, 2023

What does this PR try to resolve?

How should we test and review this PR?

rustbot commented Feb 4, 2023

weihanglo commented Feb 4, 2023

epage commented Feb 4, 2023

Muscraft left a comment • edited Loading

Choose a reason for hiding this comment

weihanglo commented Feb 4, 2023

ehuss commented Feb 5, 2023

bors commented Feb 5, 2023

bors commented Feb 5, 2023

bors commented Feb 5, 2023

ehuss commented Feb 6, 2023

weihanglo commented Feb 8, 2023

bors commented Feb 8, 2023

bors commented Feb 8, 2023

weihanglo commented Feb 8, 2023

ehuss commented Feb 9, 2023

bors commented Feb 9, 2023

bors commented Feb 9, 2023

bors commented Feb 9, 2023

bors commented Feb 9, 2023

chore: autolabel more for `A-*` #11679

chore: autolabel more for `A-*` #11679

Muscraft left a comment •

edited

Loading