Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Warn nightly users if rls is missing in the active toolchain #217

Closed
m-rutter opened this issue Dec 26, 2017 · 3 comments
Closed

Warn nightly users if rls is missing in the active toolchain #217

m-rutter opened this issue Dec 26, 2017 · 3 comments

Comments

@m-rutter
Copy link

m-rutter commented Dec 26, 2017

So I've been fighting for the past couple hours with rls-preview on the latest nightly build after doing an unwise rustup update. Turns out rls is missing in the latest nightly and has been missing on and off for the past few weeks due to breaking changes in nightly (as is to be expected).

rust-lang/rls#611

While trying to work out what was the last working nightly/rls release I saw it mentioned in the issue linked above that rls has a release on stable now (yay!), and sure enough setting rust-client.channel to stable got rls working again with this extension. Might it make sense to default to stable rather than asking the user if they want to install the latest nightly, which has a small chance of missing rls-preview?

@Xanewok
Copy link
Member

Xanewok commented Dec 30, 2017

Current design, as in #179, is to default to user's current default toolchain.

I do recognize that ergonomics regarding rustup update with possibly missing rls component on nightly (hopefully fixed later by rust-lang/rustup#1277) are far from perfect and need a lot of work. Also thanks to rust-lang/rust#46554 tool management will be easier and so hopefully rls breakage should occur a lot less frequently from now on.

One idea how to improve the ergonomics is to warn nightly users if active toolchain has no rls component and to detect and suggest newest nightly that has the component available. I'll change the title to better reflect work left to do.

@Xanewok Xanewok changed the title Default to stable Warn nightly users if rls is missing in the active toolchain Dec 30, 2017
@m-rutter
Copy link
Author

m-rutter commented Jan 1, 2018

Yes, it makes much better sense to have it default to the active toolchain over stable.

@m-rutter
Copy link
Author

m-rutter commented Oct 8, 2018

I think this has now been addressed. rls-vscode now defaults to the default toolchain set by rustup, and rustup no longer updates nightly if there is no upgrade path for a something like RLS.

@m-rutter m-rutter closed this as completed Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants