Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Use "Dedicated" instead of "New" panel when building tasks #399

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Use "Dedicated" instead of "New" panel when building tasks #399

merged 1 commit into from
Aug 24, 2018

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Aug 18, 2018

It is required to press a key to close the terminal in vscode.

image

With current task settings, if I forget to close the terminal after seeing build information and keep building the project, there'll be hundreds of terminals in the background.

Therefore, I think it's better to use "Dedicated" instead of "New" in this setting. Each task occupies its own terminal, and there won't be so many terminals in the background.

@skyzh
Copy link
Contributor Author

skyzh commented Aug 18, 2018

Have no idea why travis check failed...

> rust@0.4.9 compile /home/travis/build/rust-lang-nursery/rls-vscode
> tsc -p ./
node_modules/vscode-languageclient/lib/client.d.ts:1:707 - error TS2305: Module ''vscode'' has no exported member 'DocumentSymbol'.
1 import { TextDocumentChangeEvent, TextDocument, Disposable, OutputChannel, FileSystemWatcher as VFileSystemWatcher, DiagnosticCollection, Diagnostic as VDiagnostic, Uri, ProviderResult, CancellationToken, Position as VPosition, Location as VLocation, Range as VRange, CompletionItem as VCompletionItem, CompletionList as VCompletionList, SignatureHelp as VSignatureHelp, Definition as VDefinition, DocumentHighlight as VDocumentHighlight, SymbolInformation as VSymbolInformation, CodeActionContext as VCodeActionContext, Command as VCommand, CodeLens as VCodeLens, FormattingOptions as VFormattingOptions, TextEdit as VTextEdit, WorkspaceEdit as VWorkspaceEdit, Hover as VHover, CodeAction as VCodeAction, DocumentSymbol as VDocumentSymbol, DocumentLink as VDocumentLink, TextDocumentWillSaveEvent, WorkspaceFolder as VWorkspaceFolder, CompletionContext as VCompletionContext } from 'vscode';

@jens1o
Copy link

jens1o commented Aug 18, 2018

Really like it. I also think it is really annoying.

@nrc nrc merged commit 4cc70af into rust-lang:master Aug 24, 2018
@nrc
Copy link
Member

nrc commented Aug 24, 2018

THanks for the PR! I'm also not sure about the CI fail, looks like maybe we're a bit out of date. In any case I'm pretty sure it's not this PR.

@jens1o
Copy link

jens1o commented Aug 24, 2018

@nrc When will be there a new release?

@nrc
Copy link
Member

nrc commented Aug 24, 2018

@nrc When will be there a new release?

I don't have one planned, but could do one next week

@skyzh skyzh deleted the patch-1 branch August 24, 2018 09:43
@jens1o
Copy link

jens1o commented Aug 26, 2018

@skyzh
Copy link
Contributor Author

skyzh commented Aug 26, 2018

@jens1o Completely forget this... Maybe you can help make a PR?

@skyzh skyzh restored the patch-1 branch August 26, 2018 15:38
@skyzh skyzh deleted the patch-1 branch August 26, 2018 15:38
@skyzh skyzh restored the patch-1 branch August 26, 2018 15:40
@skyzh
Copy link
Contributor Author

skyzh commented Aug 26, 2018

@jens1o Thank you for reminding me, I've made another PR :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants