This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Make spinner consistent despite multiple running diagnostics #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but r? @jonathandturner |
|
Thank you! |
Xanewok
pushed a commit
to Xanewok/rls-vscode
that referenced
this pull request
Mar 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes when modifying code the spinner behaved erratically - it could sometimes appear as stuck or be spinning very, very fast. Upon further inspection it seems that it's related to multiple timers updating status bar message at at different times.
Making it use at most 1 timer seems to have fixed the problem. From what I read about Node.JS architecture/intervals, access to spinnerTimer should be safe, as there's only single thread executing interval callbacks.
I'm not a JS/JS developer myself, so I'm open to any suggestions regarding this change. It's a minuscule change, but I hope it still has some value :)