Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark + light svg versions of rust-social-wide #1944

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

onefifth
Copy link
Contributor

@onefifth onefifth commented Apr 2, 2024

Matched the font (Fria Sans) from the existing rust-social-wide.jpg

These icons are intended for use in the rust-lang GitHub readme via rust-lang/rust#123093

Closes #1943

Matched the font (Fria Sans) from the existing rust-social-wide.jpg
@onefifth onefifth requested a review from a team as a code owner April 2, 2024 23:16
@Manishearth
Copy link
Member

Seems useful for the rust project.

@Manishearth Manishearth merged commit e60d6d6 into rust-lang:master Apr 2, 2024
1 check passed
@Urgau
Copy link
Member

Urgau commented Apr 3, 2024

Thanks you very much for adding those, I spend way to much time creating one from the JPEG variant.

@onefifth I don't think it's intended but on my system the text is not rendered properly (the font is not right and the text is cut off).

image
(the text should probably be converted to outlines directly in the svg)

EDIT: just saw the PR on my repo where you mention that it is expected but I still find this unexpected; I would assume that the website would provide images (and SVG) that are ready to be used (and not half-ready/half-unusable); in particular since we don't control where it's going to be used

@onefifth
Copy link
Contributor Author

onefifth commented Apr 3, 2024

@Urgau Huh weird! I was matching the way the esbuild SVG logo you'd referenced handled text.

I'll take a look and update with a converted to path version in a few hours.

My readme pull request won't need updating as the SVG URLs in the readme won't change.

@Urgau
Copy link
Member

Urgau commented Apr 3, 2024

Inspired by our attempt to make it a SVG. I took a stab at it. That's what I got, it's not perfect but I think it's a good start.

7pndz1prpjblujki9kt

I used the official blank Rust logo: https://github.com/rust-lang/rust-artwork/blob/master/logo/rust-logo-blk.svg
And the Google Font to Svg Path project to create the text outlines.

Settings used in Google Font to Svg Path

screenshot

Dark variant

9m397a26mtflujmudz4

@onefifth
Copy link
Contributor Author

onefifth commented Apr 3, 2024

Opened a new issue #1946 and matching PR #1947 with updated SVGs

@onefifth onefifth deleted the social-media-svg-icons branch April 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark + Light SVG versions of rust-social-wide.jpg
3 participants