Update to handlebars v5 #1971
Merged
Update to handlebars v5 #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senekor
commented
May 23, 2024
Comment on lines
-159
to
+162
| return Err(RenderError::new( | ||
| return Err(RenderErrorReason::ParamNotFoundForIndex( | ||
| "{{team-text}} must have at least two parameters", | ||
| )); | ||
| 0, | ||
| ) |
There was a problem hiding this comment.
This wasn't a hard error, only a deprecation warning. I hope the variants I chose make some sense. It's a bit late.
| @@ -137,6 +137,5 @@ fn main() { | |||
| src="/static/images/ferris.gif" /> | |||
| </div> | |||
| </section> | |||
| {{> components/tools/install-script }} | |||
There was a problem hiding this comment.
This file was removed in a commit from 2019. It seems that until now, handlebars silently ignored the missing component. I believe the new error was introduced in this PR The result was that the server would crash on the get-started page and the user would see a 404.
There was a problem hiding this comment.
I clicked trough a bunch of the pages on the website looking for other occurrances, but couldn't find any. I could've missed something though.
Manishearth
approved these changes
May 24, 2024
|
We should carefully check staging before deploying this one. But it should be fine |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1918