Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intel-mkl-tool: Compilation problem with anyhow 1.0.49 #68

Closed
relf opened this issue Nov 28, 2021 · 7 comments · Fixed by #70
Closed

intel-mkl-tool: Compilation problem with anyhow 1.0.49 #68

relf opened this issue Nov 28, 2021 · 7 comments · Fixed by #70

Comments

@relf
Copy link

relf commented Nov 28, 2021

Following the release of anyhow 1.0.49, I get the following compilation error:

  
...
   Compiling ndarray-linalg v0.14.1
   Compiling zstd v0.5.4+zstd.1.4.7
   Compiling intel-mkl-tool v0.2.0+mkl2020.1
error[E0532]: expected tuple struct or tuple variant, found function `Ok`
  --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/intel-mkl-tool-0.2.0+mkl2020.1/src/entry.rs:75:16
   |
75 |         if let Ok(dir) = std::env::var("OUT_DIR") {
   |                ^^ not a tuple struct or tuple variant
   |
help: consider importing one of these items instead
   |
1  | use core::result::Result::Ok;
   |
1  | use std::result::Result::Ok;
   |
...

It seems like the new Ok() function introduced in anyhow breaks the code. see anyhow 1.0.49 release. Pinning anyhow to 1.0.48 solves the problem.
@dtolnay, to also bring this to your attention.

@YuhanLiin
Copy link

Issue is the use anyhow::*; in lib.rs, which reexports every item in anyhow internally. Since entry.rs has the line use crate::*;, it also imports every item in anyhow, including Ok.

YuhanLiin added a commit to rust-ml/linfa that referenced this issue Nov 28, 2021
Temporary CI fix (until rust-math/intel-mkl-src#68 resolves)
danieldk added a commit to finalfusion/reductive that referenced this issue Nov 29, 2021
danieldk added a commit to finalfusion/reductive that referenced this issue Nov 29, 2021
danieldk added a commit to finalfusion/reductive that referenced this issue Nov 29, 2021
hombit added a commit to hombit/intel-mkl-src that referenced this issue Dec 1, 2021
Remove wildcard `use` statements from `intel-mkl-tool`, because it
causes problems like rust-math#68
@hombit
Copy link
Contributor

hombit commented Dec 13, 2021

I've opened #70 to fix it, but we need @termoshtt or another maintainer to merge it

@JHenneberg
Copy link

same happens for me using

ndarray = "0.15"
ndarray-linalg = { version = "0.13", features = ["intel-mkl-system"] }

@hombit maybe creating a new fork and continue the developing there if the original author is not handing over this repo or assign new maintainer.

@hombit
Copy link
Contributor

hombit commented Mar 16, 2022

@JHenneberg I wrote an email to @termoshtt asking to add new contributors to this repo (or to the org). Let's wait for a few days

@njaard
Copy link

njaard commented Mar 16, 2022

I tried as well December 16, no reply.

Therefor I propose volunteers to fork the repository. My enthusiasm to do so myself is 4/10, so I'll give it a few days and fork it myself if someone else doesn't.

@JHenneberg
Copy link

@JHenneberg I wrote an email to @termoshtt asking to add new contributors to this repo (or to the org). Let's wait for a few days

any answer on your site?

@hombit
Copy link
Contributor

hombit commented Mar 25, 2022

@JHenneberg no answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants